Add Wetherspoons Pub

[doublah]

Brand Name
Wetherspoons (also referred to as J D Wetherspoon, JD Wetherspoon, Wetherspoon in current tags)
amenity=pub

Country Codes:
gb, ie

https://www.jdwetherspoon.com/pubs/all-pubs
Pretty much all Wetherspoons are seperately named pubs with wetherspoon branding (going by their website, only 9 out of the almost 900 pubs have "Wetherspoon(s)" in the name).
This means most current tagging is very inconsistent with most currently using various operator= tags (see https://taginfo.openstreetmap.org/search?q=Wetherspoon#values and https://taginfo.openstreetmap.org/search?q=Wetherspoons#values )

Wiki:
https://en.wikipedia.org/wiki/Wetherspoons
https://www.wikidata.org/wiki/Q6109362

[tohaklim]

Wondering if this might work with an operator matchnames string.
This would also need to preserve the current name tag.
Looking into this, I think even though there are still mentions of operator:wikidata in the code, operator entries were dropped from the index after #2816 so not sure how this might be supported for JDW

[bhousel]

This was done in #3103 🍻

[doublah]

Would still be nice if we had a way to matchnames for operators, plus needs an ie country code.

[bhousel]

Would still be nice if we had a way to matchnames for operators, plus needs an ie country code.

Good catch, I added the ie code in 21aec57

We don't include operator tags in this index because they have historically been misused, but we will probably add something eventually.
(see #2816, but we are considering relaxing this rule per #2928)

[doublah]

Reopening as was undone in b9c2087

Probably need to think about a better way to deal with brands with obvious branding like this but with unique location names.

[UKChris-osm]

I'm not sure how well linked the NSI is with the iD Editor, but for a brand like Wetherspoon, could the matching occur if someone were to add a node or way and search for the tag "JD Wetherspoon", and have the name element itself appear within iD (like a preset) yet remain empty, and hence invite the mapper to add the name?

"amenity/pub|JD Wetherspoon": {
"countryCodes": ["gb"],
"matchNames": [ "JD Wetherspoons", "Wetherspoons", "Wetherspoon"],
"tags": {
"amenity": "pub",
"brand": "JD Wetherspoon",
"brand:wikidata": "Q6109362",
"brand:wikipedia": "en:Wetherspoon",
"name": REQUIRED
}
}

... or does the name within the tags section need to match that at the start of the "amenity/pub|name"??

[bhousel]

... or does the name within the tags section need to match that at the start of the "amenity/pub|name"??

☝️ yes, it's this. All the code in this project is written to treat the identifier as key/value|name. For many years, both the NSI project and iD treated the name tag as the only identifier. brand tags and wikidata were not a thing until 2018. (see my talk for some history!)

Also, the index is only set up to work with brand keys (not network or operator), so this is another obvious limitation that we want to move beyond. So we can map transit features, or other things where the operator is really the identifier.

I do want to relax these limitations eventually! For now, just try to add things to the index that are consistently named.

[bhousel]

I do want to relax these limitations eventually! For now, just try to add things to the index that are consistently named.

Update on the above - the name field is not strictly required anymore now that we have new identifiers (#3995) and more flexible code to work with them 🎊

[UKChris-osm]

Wetherspoon added back via 50059d4, minus the "name" tag.

[UKChris-osm]

I'm not really up on Wikimedia uploads, but as Wetherspoon doesn't have any social media links, and as such doesn't have any logo associated with the entry in the NSI at the moment, would the app icon be suitable as a Wikimedia upload? Would it even be allowed?

[ghost]

Yes, I think that would be well within the originality limits per PD-textlogo. I can make and upload an SVG version if you'd like.

[UKChris-osm]

@ArloJamesBarnes If you're able to do that it would be great 🥇

[kymckay]

@ArloJamesBarnes Are you sure? The level of originality required for copyright protection in the United Kingdom is very low in comparison to elsewhere, most UK origin logos don't qualify for commons.

[ghost]

Ah, it seems you are correct. Thanks for catching that. https://commons.wikimedia.org/wiki/Commons:Copyright_rules_by_territory/United_Kingdom#Typographical_copyright

[UKChris-osm]

I've sent an email to Wetherspoons to see if they will grant permission for the app logo to be used on Wikimedia, so have to wait and see now.

[bhousel]

I'd like to close this issue here, as a lot of work has been done on the NSI side to allow branded pubs to exist with unique names.

There will always be followup work to do on keeping the Weatherspoons wikidata page updated, but for things like making sure their logo image looks good I don't want an open issue in our tracker.