Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update logic add genesis account #408

Merged
merged 4 commits into from
Feb 2, 2023
Merged

feat: update logic add genesis account #408

merged 4 commits into from
Feb 2, 2023

Conversation

ThanhNhann
Copy link

Closes: #XXX

What is the purpose of the change

Simplify the logic for adding accounts to genesis, the first step to solve this issue: osmosis-labs/osmosis#1628

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@ThanhNhann ThanhNhann requested a review from a team February 1, 2023 06:38
@ThanhNhann ThanhNhann marked this pull request as draft February 1, 2023 06:51
@ThanhNhann ThanhNhann marked this pull request as ready for review February 1, 2023 07:33
@ThanhNhann ThanhNhann changed the title update logic add genesis account feat: update logic add genesis account Feb 2, 2023
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/auth/helpers/genaccounts.go Outdated Show resolved Hide resolved
Co-authored-by: Roman <roman@osmosis.team>
@p0mvn p0mvn merged commit 7778778 into osmosis-labs:osmosis-main Feb 2, 2023
mergify bot pushed a commit that referenced this pull request Feb 8, 2023
* update logic add genesis account

* fix wrong name file

* feat: update changelog

* delete extra white space

Co-authored-by: Roman <roman@osmosis.team>

---------

Co-authored-by: Roman <roman@osmosis.team>
(cherry picked from commit 7778778)
p0mvn pushed a commit that referenced this pull request Feb 8, 2023
* update logic add genesis account

* fix wrong name file

* feat: update changelog

* delete extra white space

Co-authored-by: Roman <roman@osmosis.team>

---------

Co-authored-by: Roman <roman@osmosis.team>
(cherry picked from commit 7778778)

Co-authored-by: Nguyen Thanh Nhan <thanhnhan98qh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants