(Deposit/Withdraw) Show external URLs when assets has no supported chains

[JoseRFelix]

What is the purpose of the change:

This PR fixes the issue of non-Cosmos chains not being selectable in the Deposit/Withdraw flow, which blocks users from proceeding with assets like ICP. It ensures these chains can be selected by skipping provider queries and directly suggesting external bridge interfaces.

Linear Task

https://linear.app/osmosis/issue/FE-1298/need-to-be-able-to-transfer-assets-with-non-cosmos-counterparties

Testing and Verifying

• Selecting ICP displays external URLs and hides chain selection

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 5:14am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Dec 18, 2024 5:14am
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Dec 18, 2024 5:14am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Dec 18, 2024 5:14am
osmosis-testnet	⬜️ Ignored (Inspect)			Dec 18, 2024 5:14am

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/web/components/bridge/amount-and-review-screen.tsx

Oops! Something went wrong! :(

ESLint: 8.50.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/packages/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces a new state variable hasNoSupportedChains in the AmountAndReviewScreen and AmountScreen components to handle scenarios where no supported blockchain chains are available. This variable is computed based on the loading state of supported assets and the number of supported chains. The changes modify the UI rendering logic to conditionally display or hide certain components when no supported chains are present, ensuring a more robust user interface for bridge transactions.

Changes

File	Change Summary
packages/web/components/bridge/amount-and-review-screen.tsx	Added hasNoSupportedChains state variable to check availability of supported chains
packages/web/components/bridge/amount-screen.tsx	Updated AmountScreenProps interface to include hasNoSupportedChains prop, modified rendering logic to handle absence of supported chains

Sequence Diagram

sequenceDiagram
    participant AmountAndReviewScreen
    participant AmountScreen
    
    AmountAndReviewScreen->>AmountScreen: Pass hasNoSupportedChains
    
    alt No Supported Chains
        AmountScreen-->>UI: Hide chain selection
        AmountScreen-->>UI: Use fallback asset
    else Supported Chains Available
        AmountScreen-->>UI: Show normal bridge UI
    end

Loading

Possibly related PRs

• (Deposit/Withdraw) Address design feedback for Bitcoin deposits and withdrawals #4010: Modifies AmountScreen component, enhancing user interactions and state management, which aligns with the current changes in handling supported chains

Suggested reviewers

• jonator
• kamal-sutra

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5105742 and ee9825f.

📒 Files selected for processing (2)

• packages/web/components/bridge/amount-and-review-screen.tsx (2 hunks)
• packages/web/components/bridge/amount-screen.tsx (4 hunks)

🔇 Additional comments (5)

packages/web/components/bridge/amount-and-review-screen.tsx (2)

142-144: LGTM: Well-implemented state for handling unsupported chains

The new state variable correctly identifies when an asset has no supported chains by checking both the loading state and the length of supported chains.

---

290-290: LGTM: Proper prop passing to AmountScreen

The hasNoSupportedChains state is correctly passed to the AmountScreen component.

packages/web/components/bridge/amount-screen.tsx (3)

87-87: LGTM: Clean interface extension

The hasNoSupportedChains prop is properly added to the AmountScreenProps interface.

---

Line range hint 834-838: LGTM: Well-structured conditional rendering

The condition properly handles the loading state and unsupported chains case, ensuring appropriate UI rendering.

---

849-860: LGTM: Good fallback implementation for unsupported chains

The implementation gracefully falls back to the canonical asset when no supported chains exist, ensuring a smooth user experience.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.