(Deposit/Withdraw) Resolve initial layout race condition

[JoseRFelix]

What is the purpose of the change:

After #4017, there is a brief period where external URLs are displayed, even though the asset supports quotes. This PR ensures the quote layout is displayed first, as intended.

Linear Task

https://linear.app/osmosis/issue/FE-1298/need-to-be-able-to-transfer-assets-with-non-cosmos-counterparties

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 4:10pm

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Dec 18, 2024 4:10pm
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Dec 18, 2024 4:10pm
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Dec 18, 2024 4:10pm
osmosis-testnet	⬜️ Ignored (Inspect)			Dec 18, 2024 4:10pm

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/web/components/bridge/amount-and-review-screen.tsx

Oops! Something went wrong! :(

ESLint: 8.50.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/packages/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request modifies the logic for handling supported chains in the AmountAndReviewScreen and AmountScreen components. The key change is renaming the variable hasNoSupportedChains to hasSupportedChains, inverting the boolean logic to more clearly represent the presence of supported chains. This update affects how the components determine and display chain support, with adjustments to loading state checks and conditional rendering based on the new property.

Changes

File	Change Summary
packages/web/components/bridge/amount-and-review-screen.tsx	- Renamed hasNoSupportedChains to hasSupportedChains - Updated condition to check for supported chains
packages/web/components/bridge/amount-screen.tsx	- Updated AmountScreenProps interface - Changed prop from hasNoSupportedChains to hasSupportedChains - Modified loading state and rendering logic

Suggested reviewers

• jonator
• DavideSegullo

Possibly related PRs

• (Deposit/Withdraw) Show external URLs when assets has no supported chains #4017: Introduced the initial hasNoSupportedChains state variable to the AmountAndReviewScreen component, which is directly related to the current changes in chain support logic

Note: No sequence diagram is generated as the changes primarily involve boolean logic renaming and do not introduce significant new control flow or interactions.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ddc917 and 5fe2df3.

📒 Files selected for processing (2)

• packages/web/components/bridge/amount-and-review-screen.tsx (2 hunks)
• packages/web/components/bridge/amount-screen.tsx (5 hunks)

🔇 Additional comments (6)

packages/web/components/bridge/amount-and-review-screen.tsx (2)

142-143: Improved state handling with positive condition

The renamed variable hasSupportedChains makes the code more intuitive and prevents the race condition by properly checking both the loading state and chain support.

---

289-289: LGTM: Consistent prop passing

The hasSupportedChains prop is correctly passed to the AmountScreen component, maintaining consistency with the variable name change.

packages/web/components/bridge/amount-screen.tsx (4)

87-87: LGTM: Clean interface update

The AmountScreenProps interface is correctly updated with the new hasSupportedChains boolean property.

---

669-675: Improved loading state logic with clear documentation

The loading state logic is enhanced to only consider asset loading when supported chains exist. The comments effectively explain the reasoning behind this change, making the code more maintainable.

---

838-840: Enhanced conditional rendering logic

The condition for showing external bridge suggestions is now more intuitive with the positive hasSupportedChains check, helping prevent the race condition.

---

850-857: Well-structured UI rendering logic

The UI rendering logic correctly uses hasSupportedChains to control the display of chain selection and asset suggestion components. The code includes clear comments explaining the fallback logic for unsupported chains.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.