Delete some legacy code for delaying when lockup unbonds are possible (…

…#8030) (#8038)

* Delete some legacy code for delaying when lockup unbonds are possible

* Update changelog

(cherry picked from commit e98d023)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

CHANGELOG.md

@@ -44,6 +44,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### State Breaking
 
+* [#8030](https://github.com/osmosis-labs/osmosis/pull/8030) Delete legacy behavior where lockups could not unbond at very small block heights on a testnet.
+
 ### State Compatible
 
 ## v24.0.1

x/lockup/abci.go

@@ -14,13 +14,8 @@ func BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock, k keeper.Keeper)
 
 // Called every block to automatically unlock matured locks.
 func EndBlocker(ctx sdk.Context, k keeper.Keeper) []abci.ValidatorUpdate {
-	// disable automatic withdraw before specific block height
-	// it is actually for testing with legacy
-	MinBlockHeightToBeginAutoWithdrawing := int64(6)
-	if ctx.BlockHeight() < MinBlockHeightToBeginAutoWithdrawing {
-		return []abci.ValidatorUpdate{}
-	}
-
+	// TODO: Change this logic to "know" when the next unbonding time is, and only unlock at that time.
+	// At each unbond, do an iterate to find the next unbonding time and wait until then.
 	// delete synthetic locks matured before lockup deletion
 	k.DeleteAllMaturedSyntheticLocks(ctx)