Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete some legacy code for delaying when lockup unbonds are possible #8030

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Delete some legacy code for delaying when lockup unbonds are possible #8030

merged 2 commits into from
Apr 13, 2024

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Apr 12, 2024 •
edited by coderabbitai bot
Loading

I have no idea why this was here. It could affect testnets, but will not affect mainnet.

Also remark a TODO for improving the lockup speed logic

Summary by CodeRabbit

  • Refactor
    • Updated the logic for unlocking matured locks to defer until the next unbonding time, enhancing the processing efficiency.

@ValarDragon ValarDragon added the V:state/breaking State machine breaking PR label Apr 12, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 12, 2024 •
edited
Loading

Walkthrough

The recent changes focus on enhancing the functionality related to lockups and unbonding. The update eliminates legacy behavior that hindered unbonding at small block heights on a testnet. Additionally, the EndBlocker function in abci.go now defers the unlocking of matured locks until the next unbonding time, streamlining the process effectively.

Changes

File Change Summary
CHANGELOG.md Removed legacy behavior preventing unbonding at small block heights on a testnet.
x/lockup/abci.go Revised logic in the EndBlocker function to defer unlocking matured locks until the next unbonding time.

🐇✨
In the land of code where the bits all roam,
Changes are made, refining our home.
Locks now wait with a patient cheer,
Until the unbonding time draws near.
Hoppity hop, the updates flow,
In the heart of the blockchain, they glow!
🌟🔓

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a596101 and ba4b4e2.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

x/lockup/abci.go Show resolved Hide resolved
czarcas7ic
czarcas7ic approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this pretty much state compatible?

If agreed lets just add the label and I will backport so we reduce diff of PRs when it comes time for QA.

@ValarDragon
Copy link
Member Author

SGTM

@czarcas7ic czarcas7ic added A:backport/v24.x backport patches to v24.x branch V:state/compatible/backport State machine compatible PR, should be backported and removed V:state/breaking State machine breaking PR labels Apr 13, 2024
@czarcas7ic czarcas7ic merged commit e98d023 into main Apr 13, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the dev/delete_legacy_code branch April 13, 2024 01:30
mergify bot pushed a commit that referenced this pull request Apr 13, 2024
@ValarDragon @mergify
Delete some legacy code for delaying when lockup unbonds are possible (…
d993574 
…#8030)

* Delete some legacy code for delaying when lockup unbonds are possible

* Update changelog

(cherry picked from commit e98d023)
@mergify mergify bot mentioned this pull request Apr 13, 2024
Merged
ValarDragon added a commit that referenced this pull request Apr 13, 2024
@mergify @ValarDragon
Delete some legacy code for delaying when lockup unbonds are possible (…
e874c8f 
…#8030) (#8038)

* Delete some legacy code for delaying when lockup unbonds are possible

* Update changelog

(cherry picked from commit e98d023)

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
This was referenced Apr 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
A:backport/v24.x backport patches to v24.x branch C:x/lockup V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @czarcas7ic