Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to go1.18 #1177

Merged
merged 2 commits into from
Apr 5, 2022
Merged

update to go1.18 #1177

merged 2 commits into from
Apr 5, 2022

Conversation

faddat
Copy link
Member

@faddat faddat commented Mar 30, 2022

Closes: #XXX

Description

Update Osmosis to go 1.18

Question: how can we make it also backport?


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@faddat faddat mentioned this pull request Mar 30, 2022
4 tasks
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValarDragon
Copy link
Member

Can you add a changelog entry?

@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 31, 2022
@ValarDragon
Copy link
Member

Oh I missed the changelog entry already being added. Thanks for this!

@ValarDragon ValarDragon merged commit eed3294 into main Apr 5, 2022
@ValarDragon ValarDragon deleted the faddat/go-1.18 branch April 5, 2022 14:15
mergify bot pushed a commit that referenced this pull request Apr 5, 2022
* update to go1.18

* Update CHANGELOG.md

(cherry picked from commit eed3294)

# Conflicts:
#	.github/workflows/test.yml
ValarDragon added a commit that referenced this pull request Apr 7, 2022
* update to go1.18 (#1177)

* update to go1.18

* Update CHANGELOG.md

(cherry picked from commit eed3294)

# Conflicts:
#	.github/workflows/test.yml

* Fix merge conflict

* updates

* Update CHANGELOG.md

* Adapt bez' PR for adjusting golangcilint version

* Fix auto-generation making multiple indirect required sections

* Update lint.yml

* Fix tools gofmt

Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Co-authored-by: Dev Ojha <valar@valars-roost.lan>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants