-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gofumpt #1179
Enable gofumpt #1179
Conversation
Draft PR aimed at enabling fumpt linter and using golangci-lint run --fix to make developer environments match ci
Codecov Report
@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 20.70% 20.71%
=======================================
Files 194 194
Lines 25259 25260 +1
=======================================
+ Hits 5231 5232 +1
Misses 19069 19069
Partials 959 959
Continue to review full report at Codecov.
|
None of the changes gofumpt is making seem particularly helpful to me |
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@ValarDragon do you figure that I should close this? If fumpt isn't needed, no big deal :) |
@alexanderbez if Dev would like fumpt I'll take care of the rest that you've requested here |
I guess I did set .vscode to use gofumports, so I think your right / this makes sense now |
Cool! I’ll clean this up tomorrow then |
@alexanderbez changes made :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no way for me to review the entire set of changes here, but I assume all the changes are to confirm to our linters and that there's no core business logic changes, so ACK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimmed, everything seems like import changes, newline deletes, and var vs :=
Description
PR aimed at enabling fumpt linter and using golangci-lint run --fix to make developer environments match ci
make tools
make format
Should be merged after #1177 since this also updates to go 1.18
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer