Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gofumpt #1179

Merged
merged 9 commits into from
Apr 14, 2022
Merged

Enable gofumpt #1179

merged 9 commits into from
Apr 14, 2022

Conversation

faddat
Copy link
Member

@faddat faddat commented Mar 30, 2022

Description

PR aimed at enabling fumpt linter and using golangci-lint run --fix to make developer environments match ci

  • adds make tools
  • fixes make format

Should be merged after #1177 since this also updates to go 1.18


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

faddat added 3 commits March 26, 2022 02:07
Draft PR aimed at enabling fumpt linter and using golangci-lint run --fix to make developer environments match ci
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #1179 (62b68a8) into main (271485d) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main    #1179   +/-   ##
=======================================
  Coverage   20.70%   20.71%           
=======================================
  Files         194      194           
  Lines       25259    25260    +1     
=======================================
+ Hits         5231     5232    +1     
  Misses      19069    19069           
  Partials      959      959           
Impacted Files Coverage Δ
x/claim/abci.go 0.00% <ø> (ø)
x/claim/client/cli/query.go 34.45% <ø> (ø)
x/claim/client/cli/tx.go 0.00% <ø> (ø)
x/claim/handler.go 0.00% <ø> (ø)
x/claim/keeper/claim.go 64.33% <ø> (ø)
x/claim/keeper/grpc_query.go 2.50% <ø> (ø)
x/claim/keeper/hooks.go 28.00% <ø> (ø)
x/claim/keeper/keeper.go 87.50% <ø> (ø)
x/claim/keeper/params.go 81.81% <ø> (ø)
x/claim/module.go 58.06% <ø> (ø)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271485d...62b68a8. Read the comment docs.

@faddat faddat changed the title Update Makefile Enable gofumpt Mar 30, 2022
@ValarDragon
Copy link
Member

None of the changes gofumpt is making seem particularly helpful to me

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
faddat and others added 2 commits April 12, 2022 14:13
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@faddat
Copy link
Member Author

faddat commented Apr 12, 2022

@ValarDragon do you figure that I should close this?

If fumpt isn't needed, no big deal :)

@faddat
Copy link
Member Author

faddat commented Apr 12, 2022

@alexanderbez if Dev would like fumpt I'll take care of the rest that you've requested here

@ValarDragon
Copy link
Member

ValarDragon commented Apr 12, 2022

I guess I did set .vscode to use gofumports, so I think your right / this makes sense now

@faddat
Copy link
Member Author

faddat commented Apr 12, 2022

Cool! I’ll clean this up tomorrow then

@faddat
Copy link
Member Author

faddat commented Apr 13, 2022

@alexanderbez changes made :)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way for me to review the entire set of changes here, but I assume all the changes are to confirm to our linters and that there's no core business logic changes, so ACK.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed, everything seems like import changes, newline deletes, and var vs :=

@ValarDragon ValarDragon merged commit 3c97121 into main Apr 14, 2022
@ValarDragon ValarDragon deleted the faddat/ci-same-as-laptop branch April 14, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants