Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorocksdb #704

Closed
wants to merge 3 commits into from
Closed

gorocksdb #704

wants to merge 3 commits into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Jan 2, 2022

Description

This is a simple fix that makes osmosis work properly with rocksdb.

#695

It also bumps:

  • Tendermint to v0.34.15
  • tm-db to v0.6.6

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2022

Codecov Report

Merging #704 (a9124a7) into main (aded876) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   18.69%   18.69%           
=======================================
  Files         171      171           
  Lines       23814    23814           
=======================================
  Hits         4452     4452           
  Misses      18600    18600           
  Partials      762      762           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aded876...a9124a7. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll fix merge conflicts with marko's PR for removing replaces and get it merged

@ValarDragon
Copy link
Member

ValarDragon commented Jan 4, 2022

Can you give me write access to PRs to main 😅
(I have it fixed locally)

@ValarDragon
Copy link
Member

There maybe some wierd things for allowing maintainers to commit to an organization. If so, can you just cherry-pick thee two commits:

df19a2f3d505ae1196fa8bbcb86b621ab91385f9
9bdac4f57e6a61ed36afaaa1b517688938522539

and we can get it merged?

@ValarDragon
Copy link
Member

going to push fix in second branch, so it gets in! I imagine your stacked in other things rn

@faddat
Copy link
Member Author

faddat commented Jan 6, 2022

oh hey sorry!

thank you!

@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants