Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocksDB go.mod fix (copy of @faddat's PR) #715

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Jan 5, 2022

Closes: #704

Description

Basically takes #704 and fixes merge conflicts


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon ValarDragon changed the title Dev/rocksdb69 RocksDB go.mod fix (copy of @faddat's PR) Jan 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #715 (97d63ea) into main (2e78589) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage   18.69%   18.69%           
=======================================
  Files         171      171           
  Lines       23814    23814           
=======================================
  Hits         4452     4452           
  Misses      18600    18600           
  Partials      762      762           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e78589...97d63ea. Read the comment docs.

@ValarDragon ValarDragon merged commit 28bddef into main Jan 5, 2022
@ValarDragon ValarDragon deleted the dev/rocksdb69 branch January 5, 2022 16:58
ValarDragon added a commit that referenced this pull request Jan 9, 2022
* gorocksdb

* changelog

Co-authored-by: faddat <jacobgadikian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants