Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/txfees: Make an ante-handler filter for recognizing High gas txs, and having a min gas price for them #724

Closed
ValarDragon opened this issue Jan 6, 2022 · 2 comments · Fixed by #777
Assignees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jan 6, 2022

Similar to #723 , we should make a mempool filter for high gas fee txs to have non-zero fee requirements. (Configurable by every full node operator)

E.g. if gas fee > $THRESHOLD, require minimum-gas-price to be at least x.

Would require two params in the app.toml config threshold and x. Though maybe its fine to just hardcode the threshold?

I think its probably worthwhile for governance to consider requiring this in the state machine. (Though that could also be premature with cosmwasm, unclear how cosmwasm contracts will perform gas-wise)

@ValarDragon
Copy link
Member Author

ValarDragon commented Jan 6, 2022

I suggest we hard code first $THRESHOLD=1 million gas, and get a config param for MINIMUM_GAS_PRICE.

We can probably implement this first with MINIMUM_GAS_PRICE = .01uosmo as default, and then work on getting it into the config.

@hleb-albau
Copy link
Contributor

took it

Repository owner moved this from 🕒 Todo to ✅ Done in Osmosis Chain Development Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants