Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ABI compatibility of physics-sensor lockstep #2791

Merged
merged 63 commits into from
Jul 23, 2020

Conversation

mabelzhang
Copy link
Collaborator

Created this to trigger ABI checker on Jenkins correctly (hopefully).

slekieffre and others added 30 commits November 15, 2016 11:06
… Add test world file. New test is passing.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
…ailing

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
…imestamp

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
mabelzhang added 13 commits July 9, 2020 23:34
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@iche033 iche033 marked this pull request as draft July 16, 2020 20:52
@iche033
Copy link
Contributor

iche033 commented Jul 17, 2020

ABI checker build is green! I think this PR is ready fro review :)

@iche033 iche033 marked this pull request as ready for review July 17, 2020 22:11
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Copy link
Contributor

iche033 commented Jul 17, 2020

small update to make lockstepping work for wide-angle cameras. b351913

@mabelzhang
Copy link
Collaborator Author

ubuntu gpu-none has these test failures that are not in the buildfarm CI. They all seem related to timing:

PhysicsEngines/ContactSensor.ModelRemoval/0
PhysicsEngines/ContactSensor.ModelRemoval/3
On the same line:

/var/lib/jenkins/workspace/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-none/gazebo/test/integration/contact_sensor.cc:164
Expected: (j) < (5), actual: 5 vs 5

It's waiting for topic cleanup, and they aren't being cleaned up.

PhysicsEngines/ImuTest.ImuSensorTestWorld/0

/var/lib/jenkins/workspace/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-none/gazebo/test/integration/imu.cc:303
The difference between imuMag and gMag is 9.5427824541971518e-05, which exceeds 8e-5, where
imuMag evaluates to 9.8100954278245425,
gMag evaluates to 9.8100000000000005, and
8e-5 evaluates to 8.0000000000000007e-05.

This is inside an else-if-condition (world->SimTime().Double() >= 1.85). I think it's expecting different values depending on how much time has passed.

SpeedThreadIslandsTest.MultiplePendulumQuickStep
SpeedThreadIslandsTest.MultiplePendulumWorldStep
SpeedThreadIslandsTest.DualPR2QuickStep
On the same line:

/var/lib/jenkins/workspace/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-none/gazebo/test/integration/speed_thread_islands.cc:150
Expected: (threadMinTime) < (baseMinTime), actual: 2 317337200 vs 2 89550522

It's comparing the time between threading and no threading.

I could not reproduce any of these locally... I thought we had made the timing issue better with --lockstep...

@mabelzhang
Copy link
Collaborator Author

Ooh I'm seeing all these failures in #2788 as well: https://build.osrfoundation.org/job/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-none/240/

PhysicsEngines/ContactSensor.ModelRemoval/2
PhysicsEngines/ContactSensor.ModelRemoval/3
PhysicsEngines/ImuTest.ImuSensorTestWorld/0
SpeedThreadIslandsTest.MultiplePendulumQuickStep
SpeedThreadIslandsTest.MultiplePendulumWorldStep
SpeedThreadIslandsTest.DualPR2QuickStep

This is the same set as above. So they're just flaky. I think this PR is good to go then.

@iche033
Copy link
Contributor

iche033 commented Jul 22, 2020

lockstep is working with manual testing. ABI build is fine. Approving!

@iche033 iche033 changed the title [Do not merge] Test ABI compatibility of physics-sensor lockstep Test ABI compatibility of physics-sensor lockstep Jul 22, 2020
@iche033
Copy link
Contributor

iche033 commented Jul 22, 2020

hmm we should probably give this PR a better title before merging.

@mabelzhang
Copy link
Collaborator Author

xD Thanks for changing the title. Merging!

@mabelzhang mabelzhang merged commit 6ec9700 into gazebo11 Jul 23, 2020
@mabelzhang mabelzhang deleted the respect_fps_gz11new branch July 23, 2020 00:37
@chapulina chapulina added the 11 Gazebo 11 label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Gazebo 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants