Added shininess to models #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
ahcorde
requested changes
Apr 21, 2022
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
7 tasks
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
WilliamLewww
force-pushed
the
wlew/shininess
branch
from
b8d2ffa to
429e757
Compare
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
ahcorde
requested changes
May 6, 2022
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
ahcorde
approved these changes
May 6, 2022
scpeters
added a commit
to gazebo-release/gazebo11-release
that referenced
this pull request
May 27, 2022
Follow-up to gazebosim/gazebo-classic#3213 and gazebosim/gazebo-classic#3223 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebo-release/gazebo11-release
that referenced
this pull request
May 27, 2022
Follow-up to gazebosim/gazebo-classic#3213 and gazebosim/gazebo-classic#3223 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
When using default shaders in gazebo, the ogre's default shininess is 0 causing the specular components to have no effect. Without having a shininess element, we are unable to utilize specular highlights with default shaders.
Test it: