-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added <shininess> to <material> #985
Conversation
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI
/github/workspace/include/sdf/Material.hh:119: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Codecov Report
@@ Coverage Diff @@
## sdf9 #985 +/- ##
===========================================
- Coverage 87.58% 43.47% -44.11%
===========================================
Files 63 1 -62
Lines 9963 23 -9940
===========================================
- Hits 8726 10 -8716
+ Misses 1237 13 -1224
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about also updating the Load
function to load shininess
value from SDF?
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
🎉 Added
<shininess>
to<material>
Summary
When using default shaders in gazebo, the ogre's default shininess is 0 causing the specular components to have no effect. Without having a shininess element, we are unable to utilize specular highlights with default shaders.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.