Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gzweb installation tutorial #126

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Update gzweb installation tutorial #126

merged 2 commits into from
Nov 12, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 12, 2020 •
edited
Loading

Added a new tutorial for gazebo versions 9 or above

Main changes are:

  • added additional instructions for installing nodejs
  • updated instruction to use gzweb_1.4.1 release

Signed-off-by: Ian Chen ichen@osrfoundation.org

@iche033
update gzweb install tutorial
0e32c35 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from chapulina November 12, 2020 01:21
@iche033 iche033 mentioned this pull request Nov 12, 2020
Merged
chapulina
chapulina approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a question about installing node from apt. Maybe we should just suggest nvm. Up to you.

gzweb_install/tutorial.md Outdated Show resolved Hide resolved
@iche033
update nodejs installation instructions
bcf9177 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina merged commit dcdc457 into master Nov 12, 2020
@chapulina chapulina deleted the gzweb_install_9 branch November 12, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @chapulina