-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation against gazebo 11 #194
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
great work on these build updates for Gazebo11 on Bionic unfortunately, the patches do not work to compile gzweb for Gazebo11 on Foxy/Focal |
@iche033 I was following installation instructions on http://gazebosim.org/gzweb.html#install-collapse-1 but there seems to be some dependency conflicts between npm and gazebo11 (on bionic) |
@Jaeyoung-Lim I'm using node v6.17.1, and npm 3.10.10. These versions seem to work fine and I installed them using nvm. I had issues in the past with the node and npm versions that come with ubuntu bionic. See if these versions work for you and I can update the installation instructions on gazebosim.org @mis-eu Maybe it's an issue with node and npm version too? Could you also try node v6 and npm v3? |
How about adding some CI that tests against Gazebo 7 / 9 / 11, like this one on https://github.com/osrf/gzweb/blob/master/.github/workflows/ci.yaml |
@Jaeyoung-Lim the build error is below Also failed with @iche033 suggested: Failed to build on Ubuntu Focal/Foxy/Gazebo11 the https://github.com/osrf/gzweb checked out 1.4 I even installed Boost from source. Would inking the Boost lib to the gzweb build be required? gzweb Focal/Foxy build error Ouput below
user@machine:~/gzweb$ npm run deploy --- -m
Build a local model database. Running "concat:build_gz3d" (concat) task Running "concat:build_gui" (concat) task Running "jshint:files" (jshint) task
Running "uglify:build_src" (uglify) task
Running "uglify:build_gz3d" (uglify) task
Running "uglify:build_gui" (uglify) task
Done, without errors. For input:
the old evaluation rules produce:
but the new evaluation rules produce:
Using the old result for compatibility since the policy is not set. -- Build type not selected: Release selected by default npm ERR! Linux 4.19.104-microsoft-standard npm ERR! Please include the following file with any support request: |
thanks for the suggestion @iche033 Build Error log is in comment above linked here #194 (comment) |
npm ERR! Tell the author that this fails on your system: /home/user/gzweb/npm-debug.log
|
@mis-eu Is the output and errors from the |
@iche033 that's right, in fact: this branch fix_build_gz11 outputs:
while branch gzweb_1.4 outputs:
|
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Added CI for gazebo9 on Bionic and gazebo11 on Focal with nodejs versions 8 and 10. Builds are passing. |
@iche033 thanks for the updates! Also, I had to apply both fixes in order to build with Node 10.22.1 while building with Node 6.17.11 was deprecated for running Node on Focal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the CI!
After jumping around some different node versions, I was able to build this branch against Gazebo 9 with v6.17.1
as suggested.
Once these changes get in, I can tag a gzweb_1.4.1 release and update the instructions on http://gazebosim.org/gzweb.html.
That would be great, thanks! 😄
I also tested against Gazebo 11 on Focal and it worked well with Node 6.17.1. (note that it isn't 6.17.11 - this version doesn't exist). I'm going to merge this PR since it solves the issue for at least some of us, and CI is also happy. @mis-eu , how about continuing iterating on your problem in a new issue? |
osrf/gazebo_tutorials#126 updates the gzweb installation instructions |
Made a copule changes that allowed me to build gzweb against gazebo9 and gazebo11 on Bionic:
I also fixed a link and gzweb version in package.json'
Update:
Instead making a PR against a release branch, I created a new
gzweb_1.4
dev branch for patches made against the 1.4 version. Once these changes get in, I can tag agzweb_1.4.1
release and update the instructions on http://gazebosim.org/gzweb.html.Signed-off-by: Ian Chen ichen@osrfoundation.org