Pin node-gyp back to fix GitHub Actions #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moriarty
commented
Sep 1, 2020
•
moriarty
commented
- Pin node-gyp to 6.1.0 which is the latest version where things don't break.
- update GitHub ci triggers to trigger on PRs to master and pushes to master
- previously was only set to push, which would trigger all commits pushed to this repo directly. (no CI was triggered for contributions from users without push access to this repo, unless they modify the ci files)
There may be other branches of interest.
This should fix the current failing GitHub Workflow CI job. Maybe Related: osrf/docker_images#334 See Also: osrf/docker_images#333 Using 7.0.0 or newer causes failures. Bumping all dependencies also seemed to work but brings other issues. This PR is the minimum change required.
This was referenced Sep 1, 2020
Merged
chapulina
reviewed
Sep 1, 2020
moriarty
commented
Sep 1, 2020
There was a problem hiding this comment.
@chapulina I can break out my changes to ci.yaml from the change to package.json if you want more discussion otherwise I've added details and made a suggested change
This reverts commit d9f45e3.
chapulina
approved these changes
Sep 2, 2020
FelipeGdM
pushed a commit
to FelipeGdM/gzweb
that referenced
this pull request
Feb 1, 2021
This should fix the current failing GitHub Workflow CI job. Maybe Related: osrf/docker_images#334 See Also: osrf/docker_images#333 Using 7.0.0 or newer causes failures. Bumping all dependencies also seemed to work but brings other issues. This PR is the minimum change required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.