Skip to content

Commit

Permalink
Pin node-gyp back to fix GitHub Actions (#192)
Browse files Browse the repository at this point in the history
This should fix the current failing GitHub Workflow CI job.

Maybe Related: osrf/docker_images#334
See Also: osrf/docker_images#333

Using 7.0.0 or newer causes failures.
Bumping all dependencies also seemed to work but brings other issues.
This PR is the minimum change required.
  • Loading branch information
moriarty authored Sep 2, 2020
1 parent 4df3145 commit fcd826d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Node.js CI

on: [push]
on: [push, pull_request]

jobs:
build:
Expand Down Expand Up @@ -29,7 +29,7 @@ jobs:
# - run: sudo chmod 755 /usr/bin/google-chrome
# - run: defaults write com.google.chrome HardwareAccelerationModeEnabled -integer 1
# - run: export DISPLAY=:0
- run: npm run deploy
- run: npm run deploy --verbose
# - run: npm test
# - run: npm run coverage
- run: npm run update
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dependencies": {
"fs": "0.0.1-security",
"http": "0.0.0",
"node-gyp": "",
"node-gyp": "6.1.0",
"path": "^0.12.7",
"websocket": "^1.0.25"
},
Expand Down

0 comments on commit fcd826d

Please sign in to comment.