Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy.sh does not handle spaces in model filenames #160

Open
osrf-migration opened this issue Nov 19, 2018 · 5 comments
Open

deploy.sh does not handle spaces in model filenames #160

osrf-migration opened this issue Nov 19, 2018 · 5 comments
Assignees
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Will Baker (Bitbucket: William Baker).


#!bash

['sed', '-i', '-e', 's/\\(\\.tga\\|\\.tiff\\|\\.tif\\|\\.jpg\\|\\.jpeg\\|\\.gif\\)/\\.png/g', 'Male.dae']
sed: can't read Male.dae: No such file or directory
error Command '['sed', '-i', '-e', 's/\\(\\.tga\\|\\.tiff\\|\\.tif\\|\\.jpg\\|\\.jpeg\\|\\.gif\\)/\\.png/g', 'Male.dae']' returned non-zero exit status 2
Traceback (most recent call last):
  File "./webify_models_v2.py", line 67, in <module>
    subprocess.check_call(sed_cmd)
  File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sed', '-i', '-e', 's/\\(\\.tga\\|\\.tiff\\|\\.tif\\|\\.jpg\\|\\.jpeg\\|\\.gif\\)/\\.png/g', 'Male.dae']' returned non-zero exit status 2

Added a model that is named Large Male

#!bash
'Large Male'
├── materials
│   └── textures
│       └── Large Male.png
├── meshes
│   └── Large Male.dae
├── model.config
└── model.sdf

gazebo 9.4.1
Gzweb on branch insert_sdf
using docker file from issue #158
and pull request #173
https://osrf-migration.github.io/gzweb-gh-pages/#!/osrf/gzweb/pull-requests/173

@osrf-migration
Copy link
Author

Original comment by Will Baker (Bitbucket: William Baker).


  • Edited issue description

2 similar comments
@osrf-migration
Copy link
Author

Original comment by Will Baker (Bitbucket: William Baker).


  • Edited issue description

@osrf-migration
Copy link
Author

Original comment by Will Baker (Bitbucket: William Baker).


  • Edited issue description

@osrf-migration
Copy link
Author

Original comment by Will Baker (Bitbucket: William Baker).


pull request #174

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 25, 2020
chapulina added a commit that referenced this issue Apr 25, 2020
Pass arg to npm run deploy

Approved-by: Louise Poubel <lupoubel@hotmail.com>
@chapulina chapulina self-assigned this Nov 11, 2020
@chapulina
Copy link
Contributor

Here's the diff from @willcbaker's PR on BitBucket:

https://github.com/osrf/gzweb/compare/willcbaker/split-files-in-webify_models_v2py-by-new-1542660156446

That fixes serving all the files, but I'm needing more fixes for the files to actually load on the browser. I'm working on this branch:

gzweb_1.4...chapulina/spaces

I have meshes and textures with spaces being properly fetched by the browser, but for some reason the texture is not showing yet. It could be an issue unrelated to the spaces, I'll keep debugging.

I'm using this PR on Gazebo's side: gazebosim/gazebo-classic#2877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

2 participants