Support resource files with spaces

[chapulina]

Resolves #160

Tested with gazebosim/gazebo-classic#2877

I rebased @willcbaker's fix and built on top of it.

Test it manually

1. Download these 2 models into ~/.gazebo/models

   • https://app.ignitionrobotics.org/chapulina/fuel/models/Stop%20sign%20with%20spaces
   • https://app.ignitionrobotics.org/chapulina/fuel/models/Cordless%20drill%20with%20spaces

2. Source gazebo/setup.sh according to your installation.

3. Set env var: GAZEBO_MODEL_PATH=$HOME/.gazebo/models:$GAZEBO_MODEL_PATH

4. Redeploy to webify local models: npm run deploy --- -m local

5. Save this world as spaces.world:

   spaces.world

   <?xml version="1.0" ?>
   <sdf version="1.5">
     <world name="default">
       <!-- A global light source -->
       <include>
         <uri>model://sun</uri>
       </include>
       <!-- A ground plane -->
       <include>
         <uri>model://ground_plane</uri>
       </include>
       <include>
         <uri>model://Stop sign with spaces</uri>
       </include>
       <include>
         <pose>3 0 0 0 0 0</pose>
         <uri>model://Cordless drill with spaces</uri>
       </include>
     </world>
   </sdf>
   
   

6. Start gzserver spaces.world -u

7. Start GzWeb: npm start

Supported file types

• Models with spaces (Stop sign with spaces / Cordless drill with spaces)
• Meshes with spaces (cordless drill.dae / cordless drill.stl / stop sign.dae)
• Material files with spaces (stop sign.material)
• Textures with spaces referenced from DAE (cordless drill.png)
• Textures with spaces referenced from Ogre material (StopSign Diffuse.png / StopSign Spec.png)

[iche033]

The Stop sign with spaces model on fuel contains references to model://Stop Sign/. After updating the URIs, the models load fine!

I also tested the model with spaces model from gazebosim/gazebo-classic#2877 but that didn't work though. Having that model in the model path and rerunning npm run deploy --- -m local also stopped the Stop sign with spaces textures from showing up.

[chapulina]

The Stop sign with spaces model on fuel contains references to model://Stop Sign/.

Woops, nice catch. I updated the model.

I also tested the model with spaces model from gazebosim/gazebo-classic#2877 but that didn't work though.

Yeah I think that model has several things unsupported by GzWeb. One is nested models (#102). But there's also something about that DAE file that GzWeb doesn't like, with spaces or without. I checked that the texture is correctly fetched by the browser, but it isn't displayed. That's why I chose to use DAE files that are known to work with GzWeb here.

Having that model in the model path and rerunning npm run deploy --- -m local also stopped the Stop sign with spaces textures from showing up.

👀 That's weird, I'll take a look.

[chapulina]

Having that model in the model path and rerunning npm run deploy --- -m local also stopped the Stop sign with spaces textures from showing up.

The problem was caused by that model having an Ogre material that contains spaces in its name. This was messing up all materials. That should be fixed now: 82ab597

It's unfortunate that a single malformed material can mess up all materials 😕

[iche033]

cool, missing texture issue is fixed for me.