Updates for GitHub #177
Merged
Updates for GitHub #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
iche033
approved these changes
Jun 4, 2020
FelipeGdM
pushed a commit
to FelipeGdM/gzweb
that referenced
this pull request
Feb 1, 2021
* Updates for GitHub Signed-off-by: Louise Poubel <louise@openrobotics.org> * install deps Signed-off-by: Louise Poubel <louise@openrobotics.org> * don't install node again Signed-off-by: Louise Poubel <louise@openrobotics.org> * update image Signed-off-by: Louise Poubel <louise@openrobotics.org> * update image Signed-off-by: Louise Poubel <louise@openrobotics.org> * update image Signed-off-by: Louise Poubel <louise@openrobotics.org> * remove node 12.x Signed-off-by: Louise Poubel <louise@openrobotics.org> * install chrome Signed-off-by: Louise Poubel <louise@openrobotics.org> * sudo all the things Signed-off-by: Louise Poubel <louise@openrobotics.org> * move sudo Signed-off-by: Louise Poubel <louise@openrobotics.org> * sudo-do-do-do-do Signed-off-by: Louise Poubel <louise@openrobotics.org> * try --disable-gpu Signed-off-by: Louise Poubel <louise@openrobotics.org> * enable HardwareAccelerationModeEnabled Signed-off-by: Louise Poubel <louise@openrobotics.org> * skip tests and coverage for now Signed-off-by: Louise Poubel <louise@openrobotics.org> * Try firefox just in case Signed-off-by: Louise Poubel <louise@openrobotics.org> * no display? Signed-off-by: Louise Poubel <louise@openrobotics.org> * give up Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed links and started porting CI to GitHub actions. The magic we used on BitBucket pipelines to run Chrome headless is not working here. I also noticed that BitBucket pipelines hasn't been working for a while.
So I left my commits here in case someone wants to see everything I tried. I tried both Firefox and Chrome with no success, so I disabled tests. The action is still checking that everything builds properly though.