Port to fcl 0.6.1 #194
Port to fcl 0.6.1 #194
Conversation
There was a problem hiding this comment.
Since this requires a non-trivial dependency change in the version of FCL, I'm concerned these changes could get stuck in PR limbo until eventually merge conflicts start to develop. To avoid that, I'd like to suggest that we tweak this PR to make it compatible with both 0.5 and 0.6 when compiling from source.
I've left inline comments to help guide the cross-compatibility effort.
| @@ -11,8 +11,7 @@ | |||
| <build_depend>rmf_utils</build_depend> | |||
| <build_export_depend>rmf_utils</build_export_depend> | |||
|
|
|||
| <build_depend>libccd-dev</build_depend> | |||
| <build_depend>libfcl-dev</build_depend> | |||
| <build_depend>fcl</build_depend> | |||
There was a problem hiding this comment.
I'm not sure what we can/should do about this to make it backwards compatible. One option might be to keep the old two build_depend tags in here for now. I don't think there's much harm in having redundant dependency declarations.
ddengster
force-pushed
the
feature/port_fcl-0.6
branch
from
ebe339e
to
73f5681
Compare
|
the upstream FCL PR flexible-collision-library/fcl#505 has been merged |
Co-authored-by: Grey <grey@openrobotics.org>
Co-authored-by: Grey <grey@openrobotics.org>
As per title.
At the moment Foxy only has fcl-0.5, so this requires some adjustments to the build process; you'll have to pull in this branch into your workspace and colcon build it.
Relevant PR with fix: flexible-collision-library/fcl#505