Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Feature/planner visualizer #45

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

aaronchongth
Copy link
Contributor

@aaronchongth aaronchongth commented May 4, 2020

Starting this PR to get feedback as the frontend gets developed. The current idea is the backend/server will receive all the necessary information from the UI to create a planner and its corresponding debugger. The Graph for the planner is more tricky, and I plan to have the UI select a file location from the browser, which the server expects to be an absolute path, to create GraphInfo instance using ParseGraph (a modified version from rmf_fleet_adapters.

Branched off develop, currently building with rmf_core commit 69f496b

TODO:

  • schedule visualizer to use json from interface library as well
  • test response from UI

@koonpeng
Copy link
Member

The Graph for the planner is more tricky, and I plan to have the UI select a file location from the browser, which the server expects to be an absolute path, to create GraphInfo instance using ParseGraph (a modified version from rmf_fleet_adapters.

I haven't look at the code but this screams a lot of problems with access control. I'm assuming the plan is to visualize a previously created graph, you could use the File API to open a file on the client side or have the server present a list of handles that the client can select.

@aaronchongth
Copy link
Contributor Author

I like the idea of server presenting list of handles for the client, thanks for the input! I will make the changes accordingly

Base automatically changed from develop to master June 11, 2020 09:56
@ddengster ddengster force-pushed the feature/planner-visualizer branch from 3b93e51 to b176805 Compare June 26, 2020 08:28
@ddengster ddengster force-pushed the feature/planner-visualizer branch from e6e5138 to 2b893be Compare July 1, 2020 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants