This repository has been archived by the owner on Jul 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Feature/planner visualizer #45
Open
aaronchongth
wants to merge
24
commits into
master
Choose a base branch
from
feature/planner-visualizer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2020
I haven't look at the code but this screams a lot of problems with access control. I'm assuming the plan is to visualize a previously created graph, you could use the File API to open a file on the client side or have the server present a list of handles that the client can select. |
I like the idea of server presenting list of handles for the client, thanks for the input! I will make the changes accordingly |
ddengster
force-pushed
the
feature/planner-visualizer
branch
from
June 26, 2020 08:28
3b93e51
to
b176805
Compare
…ng and keeping track of steps, maybe have that in the node
ddengster
force-pushed
the
feature/planner-visualizer
branch
from
July 1, 2020 02:24
e6e5138
to
2b893be
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting this PR to get feedback as the frontend gets developed. The current idea is the backend/server will receive all the necessary information from the UI to create a planner and its corresponding debugger. The
Graph
for the planner is more tricky, and I plan to have the UI select a file location from the browser, which the server expects to be an absolute path, to createGraphInfo
instance usingParseGraph
(a modified version fromrmf_fleet_adapters
.ParseGraph
was taken fromrmf_core
, https://github.com/osrf/rmf_core/blob/master/rmf_fleet_adapter/src/rmf_fleet_adapter/ParseGraph.hpp, with some modificationsjson
header to a common interface libraryvisualizer_utils
romi-dashboard
for frontend development and testing, https://github.com/osrf/romi-dashboard/blob/master/src/mock/data/planning_state.jsonBranched off
develop
, currently building withrmf_core
commit69f496b
TODO:
json
from interface library as well