Call rosdep install from cloudsim dockerfiles and remove superfluous packages #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build finished. No test results found. |
|
@peci1 , can you update your branch with the latest changes on master? |
|
Updated. |
|
Build finished. 15 tests run, 0 skipped, 0 failed. |
|
Another update with master (no conflict). I noticed the rosdep install commands were duplicated by the merge, so I only left the one command that was already there. |
|
I successfully built both of the images locally using this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #748. Due to the use of rosdep install, some packages became superfluous.
I know this might become a breaking change to some users who assume some packages have already been installed. It shouldn't be that difficult for them to add the packages to their buildscripts (probably using rosdep again).
I rather split this PR apart from #748 so that if you choose to not go so aggresively with the optimizations, you can accept only #748 and reject this PR.
This PR makes sure things like RViz aren't installed in cloudsim images, as I don't see a real use for them there. It also does just a shallow clone of the subt repo and removes build artifacts and debug symbols from the built workspace.
These changes together save about 900 MB in the sim image and 800 MB in the bridge image (according to
docker system df -v).I did basic tests of the new images and everything seems to work as it should.