Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call rosdep install from cloudsim dockerfiles #748

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

peci1
Copy link
Collaborator

@peci1 peci1 commented Jan 12, 2021

I guess this is the way to get a catkin workspace correctly up and running. Not utilizing rosdep leads to manual management of several lists of packages, which is highly error-prone.

This IMHO offers a better solution to #731 than #732 (because somebody has already specified that subt_ros package depends on compressed_image_transport as an exec dependency).

I tried building the Dockerfiles and they both build fine.

In cloudsim_sim image, the rosdep call installs:

executing command [sudo -H apt-get install -y ros-melodic-joint-trajectory-controller]
executing command [sudo -H apt-get install -y ros-melodic-controller-manager]
executing command [sudo -H apt-get install -y ros-melodic-diff-drive-controller]
executing command [sudo -H apt-get install -y ros-melodic-multimaster-launch]
executing command [sudo -H apt-get install -y ros-melodic-interactive-marker-twist-server]
executing command [sudo -H apt-get install -y ros-melodic-lms1xx]
executing command [sudo -H apt-get install -y ros-melodic-teleop-twist-joy]
executing command [sudo -H apt-get install -y ros-melodic-joint-state-controller]

In cloudsim_bridge, it installs:

executing command [sudo -H apt-get install -y ros-melodic-joint-trajectory-controller]
executing command [sudo -H apt-get install -y ros-melodic-controller-manager]
executing command [sudo -H apt-get install -y ros-melodic-diff-drive-controller]
executing command [sudo -H apt-get install -y ros-melodic-multimaster-launch]
executing command [sudo -H apt-get install -y ros-melodic-interactive-marker-twist-server]
executing command [sudo -H apt-get install -y ros-melodic-lms1xx]
executing command [sudo -H apt-get install -y ros-melodic-teleop-twist-joy]
executing command [sudo -H apt-get install -y ros-melodic-joint-state-controller]

@osrf-jenkins
Copy link

Build finished. No test results found.

@nkoenig nkoenig merged commit 9c3d00f into osrf:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants