Call rosdep install from cloudsim dockerfiles #748
Merged
+14
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this is the way to get a catkin workspace correctly up and running. Not utilizing rosdep leads to manual management of several lists of packages, which is highly error-prone.
This IMHO offers a better solution to #731 than #732 (because somebody has already specified that
subt_ros
package depends oncompressed_image_transport
as an exec dependency).I tried building the Dockerfiles and they both build fine.
In cloudsim_sim image, the rosdep call installs:
In cloudsim_bridge, it installs: