Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Install ros-ign from Debian #732

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Docker: Install ros-ign from Debian #732

merged 2 commits into from
Dec 17, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 17, 2020

Install ros-ign from debian instead of from source so that the ros image compression library is brought in.

Nate Koenig added 2 commits December 17, 2020 10:17
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@osrf-jenkins
Copy link

Build finished. No test results found.

@mjcarroll mjcarroll changed the title Ros ign debain docker Docker: Install ros-ign from Debian Dec 17, 2020
@nkoenig nkoenig merged commit a889b88 into master Dec 17, 2020
@mjcarroll mjcarroll deleted the ros_ign_debain_docker branch December 18, 2020 14:25
@peci1
Copy link
Collaborator

peci1 commented Jan 12, 2021

Isn't this fix pretty fragile?

$ apt show ros-melodic-ros-ign 2>/dev/null | grep Depends
Depends: ros-melodic-ros-ign-bridge, ros-melodic-ros-ign-gazebo-demos, ros-melodic-ros-ign-image

$ apt show ros-melodic-ros-ign-gazebo-demos 2>/dev/null | grep Depends
Depends: libignition-gazebo4-dev, ros-melodic-image-transport-plugins, ros-melodic-ros-ign-bridge, ros-melodic-ros-ign-gazebo, ros-melodic-ros-ign-image, ros-melodic-rqt-image-view, ros-melodic-rqt-plot, ros-melodic-rviz

It only installs image transport plugins because ros-melodic-ros-ign-gazebo-demos depends on them. I guess that might never change, but why not install the plugins directly? Or why not explicitly use them as a dependency of ros-ign-image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants