Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #954.
I tested each robot type using the steps described in issue #954:
rostopic pub -1 X1/cmd_vel geometry_msgs/Twist -- '[0,0,5]' '[0,0,0]'
rostopic pub -1 X1/cmd_vel geometry_msgs/Twist -- '[0,0,0]' '[0,0,0]'
I found an issue only with the X500 robot. The minimum factor that would trigger a collision was 5.2. Based on this, I updated the X500 to have a factor of 5.
The update to the
if
statement is just an extra safety check to make sure that themaps
have been initialized.Signed-off-by: Nate Koenig nate@openrobotics.org