Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix X500 kinetic energy threshold #965

Closed
wants to merge 1 commit into from
Closed

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 30, 2021

Resolves issue #954.

I tested each robot type using the steps described in issue #954:

  1. Start simulation with a cave world.
  2. rostopic pub -1 X1/cmd_vel geometry_msgs/Twist -- '[0,0,5]' '[0,0,0]'
  3. Wait for the robot to reach the grass area above the cave entrance
  4. rostopic pub -1 X1/cmd_vel geometry_msgs/Twist -- '[0,0,0]' '[0,0,0]'

I found an issue only with the X500 robot. The minimum factor that would trigger a collision was 5.2. Based on this, I updated the X500 to have a factor of 5.

The update to the if statement is just an extra safety check to make sure that the maps have been initialized.

Signed-off-by: Nate Koenig nate@openrobotics.org

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested review from caguero and acschang June 30, 2021 17:09
@nkoenig nkoenig mentioned this pull request Jun 30, 2021
Copy link
Contributor

@acschang acschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the issue on final_event and then could not reproduce the issue on this branch.

LGTM.

@iche033
Copy link
Contributor

iche033 commented Jul 9, 2021

replaced by #973

@iche033 iche033 closed this Jul 9, 2021
@nkoenig nkoenig deleted the x500_ke_fix branch September 27, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants