Improve task refresh #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide LoggedInPanel during plugin shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My testing setup:
I set up a modified runelite core branch where I can test our plugin as if it were on the hub. Not sure if it's the correct or accepted approach but it works.
You can find it here if you want to replicate:
branch commit
I configured two profiles:
I swapped worlds with the plugin panel open to force the profile change.
Before fix:
From Non-league to League => The client hung at the installing plugins. I waited about 15 minutes and it still didn't load.
From League to Non-league => I couldn't test because it hung in the above
After fix:
From Non-league to League => Small maybe 5 second hang, could just world swap + plugin installs tbh
From League to Non-league => No hang