Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks-tracker: improve profile & panel performance #7239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tylerthardy
Copy link
Contributor

@tylerthardy tylerthardy commented Jan 16, 2025

Main Changes

Reduced hang on profile switch with:

Testing Details

  • Noted significant improvements switching between profiles
  • Evidence & full testing details on our internal PR: LINK

🧁🧁 THANK YOU Runelite team for working with us during this League, despite the issues. 🧁🧁

@runelite-github-app
Copy link

@tylerthardy tylerthardy force-pushed the tasks-tracker-performance-011525 branch from 9ed495e to 836ece4 Compare January 16, 2025 00:30
Copy link
Member

@iProdigy iProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for continuing to make performance improvements - I'd suggest creating a TaskListPanel#refreshMultiple(Collection<TaskFromStruct>) method to reduce the number of taskPanels iterations (and Stream<T> creations)

then you could remove this for loop that creates a bunch of swing tasks: https://github.com/osrs-reldo/tasks-tracker-plugin/blob/12666e5c46bf320f75534038a15085711e54fb42/src/main/java/net/reldo/taskstracker/TasksTrackerPlugin.java#L522-L525

@tylerthardy
Copy link
Contributor Author

tylerthardy commented Jan 16, 2025

thanks for continuing to make performance improvements - I'd suggest creating a TaskListPanel#refreshMultiple(Collection<TaskFromStruct>) method to reduce the number of taskPanels iterations (and Stream<T> creations)

then you could remove this for loop that creates a bunch of swing tasks: https://github.com/osrs-reldo/tasks-tracker-plugin/blob/12666e5c46bf320f75534038a15085711e54fb42/src/main/java/net/reldo/taskstracker/TasksTrackerPlugin.java#L522-L525

Thanks. A bit of naivety on my side; I assumed putting them on the thread in a loop would run them concurrently, but I suppose there's only 1 thread, eh?

Will do!

@iProdigy
Copy link
Member

requires rebase

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin change waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants