Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: use the correct 'client_id' in 'on_stop/unpublish' #2627

Closed
wants to merge 10 commits into from
Closed

fix bug: use the correct 'client_id' in 'on_stop/unpublish' #2627

wants to merge 10 commits into from

Conversation

duiniuluantanqin
Copy link
Member

No description provided.

@duiniuluantanqin duiniuluantanqin linked an issue Sep 23, 2021 that may be closed by this pull request
API: After the on_stop event triggered by the HTTP Callback, the client id returned is different from the client id that triggered the on_play event, and it is always 09o0x492. #2626
Closed
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021 •
edited by winlinvip
Loading

Codecov Report

Merging #2627 (7f09326) into develop (40f8460) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2627   +/-   ##
========================================
  Coverage    59.22%   59.22%           
========================================
  Files          122      122           
  Lines        51758    51756    -2     
========================================
  Hits         30653    30653           
+ Misses       21105    21103    -2

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_http_hooks.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_http_stream.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_rtc_conn.cpp | 10.43% <0.00%> (ø) | |
| trunk/src/app/srs_app_rtmp_conn.cpp | 0.00% <0.00%> (ø) | |

'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_http_hooks.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_http_stream.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_rtc_conn.cpp | 10.43% <0.00%> (ø) | |
| trunk/src/app/srs_app_rtmp_conn.cpp | 0.00% <0.00%> (ø) | |

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 40f8460...7f09326. Read the comment docs.

TRANS_BY_GPT3

@duiniuluantanqin duiniuluantanqin changed the title fix bug: use the correct 'client_id' in 'on_stop' fix bug: use the correct 'client_id' in 'on_stop/unpublish' Sep 27, 2021
@duiniuluantanqin duiniuluantanqin marked this pull request as draft September 27, 2021 07:02
@duiniuluantanqin duiniuluantanqin deleted the fix-bug-issue-2626 branch September 27, 2021 07:03
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winlinvip winlinvip Awaiting requested review from winlinvip

@xiaozhihong xiaozhihong Awaiting requested review from xiaozhihong

Assignees
No one assigned
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
No milestone
4 participants
@duiniuluantanqin @codecov-commenter @winlinvip @johzzy