Added sample Banker NPC #2934

ghost · 2020-04-11T03:51:19Z

I added it mainly because of @Znote so we can start implementing the guild bank feature from #2214 and also provide a consistent bank NPC for users to have a base to work on

@Znote

I added it mainly because of @Znote so we can start implementing the guild bank feature from #2214 and also provide a consistent bank NPC for users to have a base to work on - Script and functions are mostly from ORTS, I just did small modifications and added the restriction to not transfer money to no vocation players - Added xml and lua npc files - Added isNumber function to compat (was going to add at global.lua but seems like it was an old and used function so better at compat) - Added playerExists(name) function, to check if offline player exists by name - Added getPlayerVocationAux(name) to get offline player vocationID by name (function by Sarah Wesker) - Added Player.transferMoneyTo and Player.withdrawMoney function by ORTS - Added isValidMoney, getMoneyCount and getMoneyWeight to lib\npc.lua

data/global.lua

data/npc/lib/npc.lua

data/npc/scripts/bank.lua

data/lib/core/player.lua

data/npc/scripts/bank.lua

data/npc/lib/npc.lua

data/npc/scripts/bank.lua

!!!!!!!!!!!!!!THIS NEED TO BE TESTED!!!!!!!!!!!!!!

ghost · 2020-04-21T18:57:55Z

please guys test these changes:
dbd2df6

data/npc/scripts/bank.lua

…into bank-npc

m4g1ch

Should the elses in lines 219, 258, 283 and 307 be replaced with:
elseif msgcontains(msg, "no") then
?

data/npc/scripts/bank.lua

ghost · 2020-06-09T14:44:38Z

If anyone is going to merge this, make sure to squash the commits and write a nice commit message.

maybe I should do a separated PR adding the functions and leave this one to NPC files only? for better review

DSpeichert · 2020-06-10T02:45:21Z

I'm fine with either.

ghost · 2020-06-10T10:54:02Z

draft until #3085 gets approval

Fixed the 5 noted issues in PR

…into bank-npc

ghost · 2020-06-15T14:26:49Z

@soul4soul @Zbizu @luanluciano93 @m4g1ch @DSpeichert
okay guys, thanks to znote now everything should be 100%, but I'd like to ask for a final review/approval since a few things have changed and your input is valuable! please refer to #3085 for the functions and this one for the npc, thanks in advance!

Give a hint that players can change their coins.

These functions were added in order for the upcoming sample `Banker` NPC #2934 and in the future for the guild balance feature #2214 - function getPlayerDatabaseInfo(name_or_guid) TFS 1.3 function that queries for player information from the database, returns a table of useful information if success, false if player doesn't exist. - function isNumber(str) used in several distros but wasn't there on compat.lua yet - function Player.transferMoneyTo(self, target, amount) - function Player.withdrawMoney(self, amount) - function Player.depositMoney(self, amount) - function isValidMoney(money) - function getMoneyCount(string) - function getMoneyWeight(money) Co-authored-by: Znote <stefan_brannfjell@live.no>

Znote · 2020-06-16T14:14:43Z

Since #3085 was merged, it is easier to test this.

Simply update your data to latest commit in master and add these files:
/data/npc/Banker.xml
https://raw.githubusercontent.com/otland/forgottenserver/97b0fb1ead758c3c3e8fa612c310afec18a72109/data/npc/Banker.xml

/data/npc/scripts/bank.lua
https://raw.githubusercontent.com/otland/forgottenserver/97b0fb1ead758c3c3e8fa612c310afec18a72109/data/npc/scripts/bank.lua

If you use Linux, you can just do this in your terminal:
First cd to the folder that has config.lua in it, then paste these commands:

cd data/npc/
wget https://raw.githubusercontent.com/otland/forgottenserver/97b0fb1ead758c3c3e8fa612c310afec18a72109/data/npc/Banker.xml

cd scripts/
wget https://raw.githubusercontent.com/otland/forgottenserver/97b0fb1ead758c3c3e8fa612c310afec18a72109/data/npc/scripts/bank.lua
ls

Restart the server (or reload npc) and do /s Banker to summon the NPC in-game.

…into bank-npc

Znote · 2020-07-13T18:50:47Z

If you look at my GuildBanker NPC:
https://github.com/otland/forgottenserver/blob/d11e44d0f9052a53534143f546da1a4a2f768753/data/npc/scripts/guildbank.lua

You see that I added a table of topics:

local topicList = {
	NONE = 0,
	DEPOSIT_GOLD = 1,
	DEPOSIT_CONSENT = 2,
	WITHDRAW_GOLD = 3,
	WITHDRAW_CONSENT = 4,
	TRANSFER_TYPE = 5,
	TRANSFER_PLAYER_GOLD = 6,
	TRANSFER_PLAYER_WHO = 7,
	TRANSFER_PLAYER_CONSENT = 8,
	TRANSFER_GUILD_GOLD = 9,
	TRANSFER_GUILD_WHO = 10,
	TRANSFER_GUILD_CONSENT = 11,
	LEDGER_CONSENT = 12
}
-- psuedo code
if npcHandler.topic[cid] == topicList.WITHDRAW_GOLD then
	count[cid] = getMoneyCount(msg)
	if count[cid] > 0 and count[cid] <= guild:getBankBalance() then
		npcHandler:say("Are you sure you wish to withdraw " .. count[cid] .. " gold from the guild " .. guild:getName() .. "?", cid)
		npcHandler.topic[cid] = topicList.WITHDRAW_CONSENT
	else
		npcHandler:say("There is not enough gold in the guild " .. guild:getName() .. ". Their available balance is currently " .. guild:getBankBalance() .. ".", cid)
		npcHandler.topic[cid] = topicList.NONE
	end
	return true
end

It makes the Lua code a bit easier to handle, since you dont need to keep track of topic numbers and what they represent.
Its a bit of a chore, but it would be nice if you could add that here.

ghost · 2020-07-13T19:44:32Z

If you look at my GuildBanker NPC:
https://github.com/otland/forgottenserver/blob/d11e44d0f9052a53534143f546da1a4a2f768753/data/npc/scripts/guildbank.lua

You see that I added a table of topics:

local topicList = {
	NONE = 0,
	DEPOSIT_GOLD = 1,
	DEPOSIT_CONSENT = 2,
	WITHDRAW_GOLD = 3,
	WITHDRAW_CONSENT = 4,
	TRANSFER_TYPE = 5,
	TRANSFER_PLAYER_GOLD = 6,
	TRANSFER_PLAYER_WHO = 7,
	TRANSFER_PLAYER_CONSENT = 8,
	TRANSFER_GUILD_GOLD = 9,
	TRANSFER_GUILD_WHO = 10,
	TRANSFER_GUILD_CONSENT = 11,
	LEDGER_CONSENT = 12
}
-- psuedo code
if npcHandler.topic[cid] == topicList.WITHDRAW_GOLD then
	count[cid] = getMoneyCount(msg)
	if count[cid] > 0 and count[cid] <= guild:getBankBalance() then
		npcHandler:say("Are you sure you wish to withdraw " .. count[cid] .. " gold from the guild " .. guild:getName() .. "?", cid)
		npcHandler.topic[cid] = topicList.WITHDRAW_CONSENT
	else
		npcHandler:say("There is not enough gold in the guild " .. guild:getName() .. ". Their available balance is currently " .. guild:getBankBalance() .. ".", cid)
		npcHandler.topic[cid] = topicList.NONE
	end
	return true
end

It makes the Lua code a bit easier to handle, since you dont need to keep track of topic numbers and what they represent.
Its a bit of a chore, but it would be nice if you could add that here.

I'll do for sure

Evil Puncker added 2 commits April 11, 2020 00:48

Update player.lua

1690e5e

DSpeichert requested changes Apr 18, 2020

View reviewed changes

updates

65dab16

luanluciano93 reviewed Apr 18, 2020

View reviewed changes

data/npc/scripts/bank.lua Outdated Show resolved Hide resolved

luanluciano93 reviewed Apr 18, 2020

View reviewed changes

data/npc/scripts/bank.lua Show resolved Hide resolved

luanluciano93 reviewed Apr 18, 2020

View reviewed changes

data/npc/scripts/bank.lua Outdated Show resolved Hide resolved

Evil Puncker added 3 commits April 18, 2020 02:25

more fixes

d4202c5

Merge branch 'master' into bank-npc

0d3fea6

no one liners

69ce7e3

DSpeichert added the needs-testing Needs testing with screenshots label Apr 18, 2020

luanluciano93 reviewed Apr 18, 2020

View reviewed changes

data/npc/scripts/bank.lua Show resolved Hide resolved

ghost commented Apr 18, 2020

View reviewed changes

data/npc/lib/npc.lua Outdated Show resolved Hide resolved

soul4soul reviewed Apr 18, 2020

View reviewed changes

data/npc/scripts/bank.lua Outdated Show resolved Hide resolved

Evil Puncker added 3 commits April 19, 2020 15:08

Update npc.lua

6570002

constants

c346c01

added weight check to change coins

dbd2df6

!!!!!!!!!!!!!!THIS NEED TO BE TESTED!!!!!!!!!!!!!!

DSpeichert added this to the 1.4 milestone Apr 23, 2020

Merge branch 'master' into bank-npc

ef0125d

Zbizu reviewed Apr 27, 2020

View reviewed changes

data/npc/scripts/bank.lua Show resolved Hide resolved

Evil Puncker added 4 commits April 28, 2020 14:41

Merge branch 'master' into bank-npc

0e2e3d7

Merge branch 'master' into bank-npc

bd34dbd

Merge branch 'bank-npc' of https://github.com/EPuncker/forgottenserver …

68f107a

…into bank-npc

Merge branch 'master' into bank-npc

543e9e7

m4g1ch reviewed May 1, 2020

View reviewed changes

data/npc/scripts/bank.lua Show resolved Hide resolved

m4g1ch reviewed May 1, 2020

View reviewed changes

data/npc/scripts/bank.lua Outdated Show resolved Hide resolved

Evil Puncker added 2 commits May 1, 2020 22:45

Merge branch 'master' into bank-npc

dd16f2e

switched FreeCapacity check

3d6cf85

Merge branch 'master' into bank-npc

286c80f

ghost marked this pull request as draft June 10, 2020 10:53

updates

5381986

ghost dismissed DSpeichert’s stale review via 5381986 June 10, 2020 10:58

Evil Puncker and others added 3 commits June 14, 2020 17:27

Update bank.lua

5f082a0

Fixed the 5 noted issues in PR

a4aebf9

Merge pull request #1 from Znote/bank-npc2

575311e

Fixed the 5 noted issues in PR

ghost marked this pull request as ready for review June 15, 2020 14:18

Evil Puncker added 2 commits June 15, 2020 11:21

Merge branch 'master' into bank-npc

5627744

Merge branch 'bank-npc' of https://github.com/EPuncker/forgottenserver …

eeffda4

…into bank-npc

ghost requested a review from DSpeichert June 15, 2020 14:24

Update bank npc response for help

97b0fb1

Give a hint that players can change their coins.

Merge branch 'bank-npc' of https://github.com/EPuncker/forgottenserver …

f7baa35

…into bank-npc

DSpeichert requested a review from a team June 22, 2020 07:06

Merge branch 'master' into bank-npc

f6888eb

using topicList

332d0c8

Znote approved these changes Jul 19, 2020

View reviewed changes

luanluciano93 approved these changes Jul 20, 2020

View reviewed changes

DSpeichert approved these changes Aug 1, 2020

View reviewed changes

DSpeichert merged commit b5c74b4 into otland:master Aug 1, 2020

ghost deleted the bank-npc branch August 1, 2020 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added sample Banker NPC #2934

Added sample Banker NPC #2934

ghost commented Apr 11, 2020 •

edited by ghost

Loading

ghost commented Apr 21, 2020

m4g1ch left a comment

ghost commented Jun 9, 2020

DSpeichert commented Jun 10, 2020

ghost commented Jun 10, 2020

ghost commented Jun 15, 2020

Znote commented Jun 16, 2020

Znote commented Jul 13, 2020

ghost commented Jul 13, 2020

Added sample Banker NPC #2934

Added sample Banker NPC #2934

Conversation

ghost commented Apr 11, 2020 • edited by ghost Loading

ghost commented Apr 21, 2020

m4g1ch left a comment

Choose a reason for hiding this comment

ghost commented Jun 9, 2020

DSpeichert commented Jun 10, 2020

ghost commented Jun 10, 2020

ghost commented Jun 15, 2020

Znote commented Jun 16, 2020

Znote commented Jul 13, 2020

ghost commented Jul 13, 2020

ghost commented Apr 11, 2020 •

edited by ghost

Loading