Added several functions mainly related to banker NPC

[ghost]

These functions were added in order for the upcoming sample banker NPC and in the future for the guild balance feature, I'd like to ask for a meticulous evaluation to avoid any error or exploit of the bank system. Please review function usefulness, names and possible enhancements

• function getPlayerDatabaseInfo(name_or_guid)
  TFS 1.3 function that queries for player information from the database, returns a table of useful information if success, false if player doesn't exist.

getMoneyWeight(money)
getMoneyCount(string)
isValidMoney(money)
isNumber(str)
getPlayerDatabaseInfo(name_or_guid)
Player.depositMoney(self, amount)
Player.withdrawMoney(self, amount)
Player.canCarryMoney(self, amount)
Player.transferMoneyTo(self, target, amount)

[Znote]

Could it be useful to have a general purpose "load player info from db" function? In order to reduce the amount of separate query requests to the SQL server?

Something along the lines of this:
https://gist.github.com/Znote/252757b013bd390e940cad65e8019fde

It returns player info (such as vocation, correct way to spell the name) upon success, false if player doesn't exist.

[Znote]

Since nothing has been altered (just added content) this won't break anything.
I have actively tested these together with #2934

[luanluciano93]

Couldn't you directly use "return tonumber (money) ~ = nil and money> 0" instead of using the isValidMoney (money) function?

[RomeroBA]

Couldn't you directly use "return tonumber (money) ~ = nil and money> 0" instead of using the isValidMoney (money) function?

Yup, and he could also code everything into a single big ugly block of code, but creating functions for stuff that might be used later is a good idea.

[ghost]

Couldn't you directly use "return tonumber (money) ~ = nil and money> 0" instead of using the isValidMoney (money) function?

one check instead of two is fine 😋 i also thought about it but someone else said to keep it and so I did

[luanluciano93]

I don't think two checks are good for something that can be done in one. To be honest, it shouldn't. use the compat.lua for nothing.