depr!: remove preview site configurations#1238
Merged
DawoudSheraz merged 1 commit intooverhangio:mainfrom Jun 18, 2025
Merged
Conversation
closes overhangio#1231 The preview page has been migrated to the Learning MFE as of openedx/openedx-platform#36460 This is why we dont need to have a separate domain for the preview site anymore nor the configuration setting for the preview page in core.
This was referenced May 22, 2025
DawoudSheraz
approved these changes
May 23, 2025
github-project-automation
bot
moved this from In review
to Done
in Tutor project management
cmltaWt0
added a commit
to raccoongang/tutor
that referenced
this pull request
Jun 20, 2025
This reverts commit c780e0a.
Danyal-Faheem
added a commit
to edly-io/tutor
that referenced
this pull request
Jun 23, 2025
This reverts commit c780e0a. We revert this commit as the upstream change was merged in the master branch and is not to be backported to teak. Therefore, the current builds running on top of teak are failing.
DawoudSheraz
pushed a commit
that referenced
this pull request
Jun 23, 2025
This was referenced Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1231.
The preview page has been migrated to the Learning MFE as of openedx/openedx-platform#36460.
This is why we dont need to have a separate domain for the preview site anymore nor the configuration setting for the preview page in core.
For operators that have a custom domain pointing to
preview.<LMS_HOST>, they can remove those DNS entries now as they are not required.