Features/octane version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s shift (Addepar#623)" (Addepar#651) This reverts commit 5efba8c.
* Update addepar-style-toolbox to fix import issue * [CHORE] allow ember-release to fail tests This is temporary until we have time to investigate what is going on.
* Upgrade linting packages * Upgrade ember-math-helpers * Upgrade ember-native-dom-helpers * Upgrade ember-angle-bracket-invocation-polyfill * Upgrade ember-fetch * Upgrade ember-cli-dependency-checker * Upgrade ember-try * Upgrade ember-auto-import * Upgrade default addon dependencies * Upgrade ember-cli-sass * Upgrade ember-compatibility-helpers * Upgrade @html-next/vertical-collection * Upgrade husky * Revert "Upgrade ember-cli-sass" This reverts commit ad3fc22.
This will allow to add the yarn.lock file and to rely on the public Addepar packages available for all.
```
{{ember-th api=r onContextMenu='actionHandler'}}
```
[CHORE] Node 6 support - pin jsdom
Fix build issue on Travis https://travis-ci.org/Addepar/ember-table/jobs/513359138 Related to san650/ember-cli-page-object#446
[CHORE] Pin ember-cli-page-object
…he end of a sort result. ``` <EmberThead @sortEmptyLast=true /> ```
Add ember-th/sort-indicator and ember-th/resize-handle
It allows to fully customize the content of `ember-th` without the need to duplicate the logic for sorting and resizing
```
{{#ember-th |columnValue columnMeta|}}
{{columnValue.name}}
{{ember-th/sort-indicator columnMeta=columnMeta}}
{{ember-th/resize-handle columnMeta=columnMeta}}
{{/ember-th}}
```
[BUGFIX] Empty values are sorted properly
[CHORE] Update to node 8
* [BUGFIX] Ensure dynamicAlias works on latest Ember There were some subtle changes on the latest Ember that made aliases and properties that include . in their name to stop working. Instead of creating dynamic aliases, we now just access the properties directly on _context, which should fix the issue. * fix release tests
* Start converting to classic classes * Finish up conversion and convert TBody
There is one issue, where we are setting properties in a computed, which did not seem to be flagged be ESLint before, but is flagged when we use a class computed. I added `// eslint-disable-next-line ember/no-side-effects, ember-best-practices/no-side-effect-cp` to get around the issue for now. @pzuraq do we need to do something else to fix this or is disabling ESLint there okay?
* thead, th, and tr to classic components * Fix some tests * Add missing attributeBindings * Use defaultTo for sortFunction and compareFunction * fix defaultTo
* Move ember-decorators to devDeps * Store functions before calling removeObserver on them
It used to return `undefined` which would lead the `delta` to be `NaN`, causing an infinite loop when resizing a leaf column.
[BUG] Setting the column width to its current value works
Change from `user/repo#sha` to `https://github.com/user/repo.git#sha` form. Yarn has a bug related to installing changed SHA versions when they are pinned in `user/repo` form, that could cause consumers of this addon (or developers of this addon) to fail to get updated dependency code via `yarn install`, see: yarnpkg/yarn#4722 (comment)
This fixes an issue where removing a column can leave a blank space in the
table because it doesn't recompute column widths. The table's `ResizeSensor`
is primarily responsible for noticing resizes and updating widths, but when a
column is removed, although the inner `table` element width changes, the
container `.ember-table` element does not change its width, and thus the
`ResizeSensor` never notices, and the column widths are not recomputed.
This modifies the `ember-thead` observer to have it call `fillupHandler` when
column count changes.
It also changes the observer in `ember-thead` to watch `columns.[]` instead
of just `columns`, because in the latter case, the `fillupHandler` will not
be called if a column was removed via mutation (e.g. `popObject`).
Adds tests for removal via both ways (mutation and `this.set('columns',
newColumns)`). Also adds tests that adding columns also causes column widths
to be computed.
Co-authored-by: Jonathan Jackson
* Update ember-classy-page-object to latest ^0.6.0 * Bump to ^0.6.1
Use the "npm version" badge since the "release" badge only shows github releases (not tags), and we don't always create an official github release when we tag a new version.
* remove legacy ember-decorators * use ember-qunit instead of ember-cli-qunit * Remove ember-legacy-class-shim docs: https://github.com/pzuraq/ember-legacy-class-shim We no longer have ES6 classes inside this addon, so we don't need the shim * Skip column reordering tests on ember release, beta, canary See: Addepar#775 * Add note that async observers are needed for Ember 3.13+ * Update README to point out Ember 3.13 regressions
* Add `observer` util to opt in to async in 3.13+ * Remove code that skips column-reordering tests for 3.13+ * Use ember 3.12 in package.json * Fix lint * change eslint no-restricted-imports messages, pr feedback * Rename imported ember observer functions, pr feedback * Fix argument order for addObserver/removeObserver * Use `settled` to fix collapse-tree tests The use of `await settled()` seems to be required to properly wait for the now-async observers to finish notifying of property changes to the collapse tree. Also: * Fix propogate typo * Replace some hardcoded for loop lengths in tests with eg `expectedValue.length`
This was introduced in Addepar#529 but never used either in that change or since, so it seems like it can be safely removed.
* Add parameterizedComponentModule helper, test w/ and w/out ember arrays * Notify using the keyName rather than the full path Fixes Addepar#776 * Run resize tests w/ and w/o emberA column/rows
The Ember 3.13 bugs are now all fixed, so remove this section. Also: run the markdown formatter over the README to clean up.
0.3.9 of Ember test selectors is very old and does not strip data-test- when using Babel 7. Bump to 2.1.0. See: https://github.com/simplabs/ember-test-selectors/releases
…omplaints Fix prettier lint errors
bugfix: first multiselection has no _lastSelectedIndex
Ember internals use an observer for attribute bindings. In this case the observer timing causes a computation based on a value which is then updated by a side-effect-having CP. Here avoid the observer interaction by instead setting the count itself as part of the computation side effects. See: * Addepar#795 * emberjs/ember.js#18613 Fixes Addepar#795
Avoids the issue with Node 8 caused by npm/node-semver@d61f828#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R35
Avoid "update prop already used in computation"
The row count did not update when the collapse of a tree was toggled. Here ensure that happens with an observer in dev mode. Fixes Addepar#804
Update test rowcount when collapse state changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.