Features/octane version

.eslintrc.js

@@ -1,15 +1,31 @@
 module.exports = {
   extends: ['@addepar', '@addepar/eslint-config/ember'],
   parser: 'babel-eslint',
-  env: {
-    es6: true,
-  },
   rules: {
     'no-restricted-globals': 'off',
 
     'ember/closure-actions': 'off',
     'ember/avoid-leaking-state-in-ember-objects': 'off',
 
     'ember-best-practices/require-dependent-keys': 'off',
-  }
+
+    'no-restricted-imports': [
+      'error',
+      {
+        paths: [
+          {
+            name: '@ember/object',
+            importNames: ['observer'],
+            message: 'For compatibility, use `import { observer } from "-private/utils/observer"`',
+          },
+          {
+            name: '@ember/object/observers',
+            importNames: ['addObserver', 'removeObserver'],
+            message:
+              'For compatibility, use `import { addObserver, removeObserver } from "-private/utils/observer"`',
+          },
+        ],
+      },
+    ],
+  },
 };

.gitignore

@@ -21,4 +21,3 @@ testem.log
 .node_modules.ember-try/
 bower.json.ember-try
 package.json.ember-try
-yarn.lock

.npmrc

@@ -0,0 +1 @@
+@addepar:registry = "https://registry.npmjs.org/"

.release-it.json

@@ -0,0 +1,12 @@
+{
+  "git": {
+    "tagName": "v${version}"
+  },
+  "github": {
+    "release": false
+  },
+  "hooks": {
+    "after:release": "yarn run docs:deploy",
+    "after:bump": "npx auto-changelog -p"
+  }
+}

.sass-lint.yml

@@ -1,2 +1,8 @@
 options:
   config-file: node_modules/@addepar/sass-lint-config/config.yml
+rules:
+  # Name Formats
+  class-name-format:
+    - 2
+    -
+      convention: strictbem

.travis.yml

@@ -3,46 +3,72 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "6"
+  - '8'
 
-sudo: required
 dist: trusty
 
 addons:
   chrome: stable
 
 cache:
   yarn: true
+  directories:
+    - node_modules
 
-global:
-  # See https://git.io/vdao3 for details.
-  - JOBS=1
 env:
-  # we recommend new addons test the current and previous LTS
-  # as well as latest stable release (bonus points to beta/canary)
-  - EMBER_TRY_SCENARIO=ember-1.12
-  - EMBER_TRY_SCENARIO=ember-1.13
-  - EMBER_TRY_SCENARIO=ember-lts-2.8
-  - EMBER_TRY_SCENARIO=ember-lts-2.18
-  - EMBER_TRY_SCENARIO=ember-release
-  - EMBER_TRY_SCENARIO=ember-beta
-  - EMBER_TRY_SCENARIO=ember-canary
-  - EMBER_TRY_SCENARIO=ember-default
-
-matrix:
-  fast_finish: true
+  global:
+    # See https://git.io/vdao3 for details.
+    - JOBS=1
+
+branches:
+  only:
+    - master
+    # npm version tags
+    - /^v\d+\.\d+\.\d+/
+
+jobs:
+  fail_fast: true
   allow_failures:
+    - env: EMBER_TRY_SCENARIO=ember-beta
+    - env: EMBER_TRY_SCENARIO=ember-canary
+
+  include:
+    # runs linting and tests with current locked deps
+
+    - stage: 'Tests'
+      name: 'Tests'
+      install:
+        - yarn install --non-interactive
+
+      script:
+        - yarn run lint
+        - yarn run test
+
+    - name: 'Floating dependencies'
+      script:
+        - yarn test
+
+    # we recommend new addons test the current and previous LTS
+    # as well as latest stable release (bonus points to beta/canary)
+    - stage: 'Additional Tests'
+      env: EMBER_TRY_SCENARIO=ember-1.12
+    - env: EMBER_TRY_SCENARIO=ember-1.13
+    - env: EMBER_TRY_SCENARIO=ember-lts-2.8
+    - env: EMBER_TRY_SCENARIO=ember-lts-2.18
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.4
+    - env: EMBER_TRY_SCENARIO=ember-lts-3.8
+    - env: EMBER_TRY_SCENARIO=ember-release
+    - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary
 
 before_install:
   - curl -o- -L https://yarnpkg.com/install.sh | bash
   - export PATH=$HOME/.yarn/bin:$PATH
 
 install:
-  - yarn install --no-lockfile --non-interactive
+  - yarn install --no-lockfile --non-interactive --ignore-engines
 
 script:
-  - yarn run lint
   # Usually, it's ok to finish the test scenario without reverting
   #  to the addon's original dependency state, skipping "cleanup".
   - node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup

.yarnrc

@@ -0,0 +1 @@
+registry "https://registry.npmjs.org/"

README.md

@@ -1,4 +1,5 @@
 [![Build Status](https://travis-ci.org/Addepar/ember-table.svg?branch=master)](https://travis-ci.org/Addepar/ember-table)
+![npm version](https://img.shields.io/npm/v/ember-table)
 
 # Ember Table
 
@@ -13,6 +14,7 @@ ember install ember-table
 ```
 
 ## Features
+
 - Column resizing, column reordering.
 - Table resizing.
 - Fixed first column.
@@ -23,9 +25,12 @@ ember install ember-table
 
 ## Documentation
 
-For more detailed documentation, clone the repo, run `yarn && yarn start` and then navigate to `http://localhost:4200/docs`
+Documentation is available at: https://opensource.addepar.com/ember-table/docs
+
+Ember Table uses [ember-cli-addon-docs](https://github.com/ember-learn/ember-cli-addon-docs) for its documentation.
+To run the docs locally, clone the repo, run `yarn && yarn start` and then navigate to `http://localhost:4200/docs`.
 
-## Usage.
+## Usage
 
 To use `Ember Table`, you need to create `columns` and `rows` dataset.
 
@@ -36,16 +41,16 @@ each row for that column. If you only want to use the default template, you can
 specify a `name` on the column which will be rendered in the template.
 
 ```javascript
-  columns: [
-    {
-      name: `Open time`,
-      valuePath: `open`
-    },
-    {
-      name: `Close time`,
-      valuePath: `close`
-    }
-  ]
+columns: [
+  {
+    name: `Open time`,
+    valuePath: `open`,
+  },
+  {
+    name: `Close time`,
+    valuePath: `close`,
+  },
+];
 ```
 
 `rows` could be a javascript array, ember array or any data structure that implements `length` and
@@ -54,21 +59,21 @@ data as user scrolls. Each object in the `rows` data structure should contains a
 by all `valuePath` in `columns` array.
 
 ```javascript
-  rows: computed(function() {
-    const rows = emberA();
+rows: computed(function() {
+  const rows = emberA();
 
-    rows.pushObject({
-      open: '8AM',
-      close: '8PM'
-    });
+  rows.pushObject({
+    open: '8AM',
+    close: '8PM',
+  });
 
-    rows.pushObject({
-      open: '11AM',
-      close: '9PM'
-    });
+  rows.pushObject({
+    open: '11AM',
+    close: '9PM',
+  });
 
-    return rows;
-  })
+  return rows;
+});
 ```
 
 ### Template
@@ -87,11 +92,11 @@ You can use the block form of the table to customize its template. The component
 structure matches that of actual HTML tables, and allows you to customize it at
 any level. At the cell level, you get access to these four values:
 
-* `value` - The value of the cell
-* `cell` - A unique cell cache. You can use this to track cell state without
+- `value` - The value of the cell
+- `cell` - A unique cell cache. You can use this to track cell state without
   dirtying the underlying model.
-* `column` - The column itself.
-* `row` - The row itself.
+- `column` - The column itself.
+- `row` - The row itself.
 
 You can use these values to customize cell in many ways. For instance, if you
 want to have every cell in a particular column use a component, you can add a
@@ -120,7 +125,6 @@ If you want to use default table style, import the `ember-table/default` SASS fi
 You can also use the `ember-tfoot` component, which has the same API as
 `ember-tbody`:
 
-
 ```
   {{#ember-table as |t|}}
     {{t.head columns=columns}}
@@ -131,19 +135,39 @@ You can also use the `ember-tfoot` component, which has the same API as
   {{/ember-table}}
 ```
 
+## Browser compatibility
+
+This project is written using an EcmaScript 6 javascript syntax.
+Babel doesn't include polyfill by default, so if you want to target legacy browsers (eg. IE11),
+you need to add this to your `ember-cli-build.js`:
+
+```js
+var app = new EmberApp({
+  'ember-cli-babel': {
+    includePolyfill: true,
+  },
+});
+```
 
 ## Migrating from old Ember table
+
 To support smooth migration from old version of Ember table (support only till ember 1.11), we have
 move the old source code to separate package [ember-table-legacy](https://github.com/Addepar/ember-table-legacy).
 It's a separate package from this Ember table package and you can install it using yarn or npm.
 This allows you to have 2 versions of ember table in your code base and you can start your migrating
 one table at at time. The recommended migration steps are as follows (if you are using ember 1.11):
 
-1) Rename all your ember-table import to ember-table-legacy. (for example:
-`import EmberTable from 'ember-table/components/ember-table'` becomes
-`import EmberTableLegacy from 'ember-table-legacy/components/ember-table-legacy'`. Remove reference
-of `ember-table` in `package.json`.
-2) Install `ember-table-legacy` using `yarn add ember-table-legacy` or `npm install ember-table-legacy`
-3) Run your app to make sure that it works without issue.
-4) Reinstall the latest version of this `ember-table` repo.
-5) You can start using new version of Ember table from now or replacing the old ones.
+1. Rename all your ember-table import to ember-table-legacy. (for example:
+   `import EmberTable from 'ember-table/components/ember-table'` becomes
+   `import EmberTableLegacy from 'ember-table-legacy/components/ember-table-legacy'`. Remove reference
+   of `ember-table` in `package.json`.
+2. Install `ember-table-legacy` using `yarn add ember-table-legacy` or `npm install ember-table-legacy`
+3. Run your app to make sure that it works without issue.
+4. Reinstall the latest version of this `ember-table` repo.
+5. You can start using new version of Ember table from now or replacing the old ones.
+
+# Releasing new versions (for maintainers)
+
+We use [`release-it`](https://github.com/release-it/release-it).
+To create a new release, run `yarn run release`. To do a dry-run: `yarn run release --dry-run`.
+The tool will prompt you to select the new release version.

addon-test-support/index.js

@@ -0,0 +1,3 @@
+import TablePage from './pages/ember-table';
+
+export { TablePage };

addon-test-support/pages/-private/ember-table-body.js

@@ -1,11 +1,24 @@
-import { alias, triggerable, collection, hasClass, property } from 'ember-classy-page-object';
+import PageObject, {
+  alias,
+  triggerable,
+  collection,
+  hasClass,
+  property,
+} from 'ember-classy-page-object';
 import { findElement } from 'ember-classy-page-object/extend';
 
 import { click } from 'ember-native-dom-helpers';
 
-export default {
+export default PageObject.extend({
   scope: 'tbody',
 
+  /**
+    Returns the number of rows in the body.
+  */
+  get rowCount() {
+    return Number(findElement(this).getAttribute('data-test-row-count'));
+  },
+
   /**
     List of rows in table body. Each of property/function in this collections is the property/func
     of a single row selected by using calling rows.objectAt(index).
@@ -73,4 +86,4 @@ export default {
   getCell(rowIndex, columnIndex) {
     return this.rows.objectAt(rowIndex).cells.objectAt(columnIndex);
   },
-};
+});

addon-test-support/pages/-private/ember-table-footer.js

@@ -1,17 +1,10 @@
 import { collection } from 'ember-classy-page-object';
+import EmberTableBody from './ember-table-body';
 
-export default {
+export default EmberTableBody.extend({
   scope: 'tfoot',
 
   footers: collection({
     scope: 'td',
   }),
-
-  rows: collection({
-    scope: 'tr',
-
-    cells: collection({
-      scope: 'td',
-    }),
-  }),
-};
+});