Remove Guided configuration #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also acb2f6f. |
ezio-melotti
commented
Dec 5, 2024
| box-sizing:border-box; | ||
| overflow:hidden; | ||
| } | ||
|
|
There was a problem hiding this comment.
Here I did some refactoring and cleaned up the CSS while I was at it.
| @@ -77,7 +77,6 @@ to the entry screens to prevent this from popping up on repeat vistors. | |||
| <script> | |||
| import {storeToRefs} from 'pinia' | |||
| import {useDashboardStore} from '../../store/modules/DashboardStore' | |||
| import {useWizardStore} from '../../store/modules/WizardStore' | |||
There was a problem hiding this comment.
By removing the guided configuration and the activeConfigType needed to select the configuration type, we no longer need to import the wizard store in the Welcome screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused Guided configuration and default to the Custom configuration in the configuration wizard.
This was triggered by the issues described in:
Before these changes, the welcome page had to import the wizard store in order to set the configuration type (Guided or Custom) before redirecting to the configuration wizard. This also happened in a number of other places. With only one type of configuration (Custom), this is no longer needed, and the wizard store doesn't need to be imported earlier.