Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #385 #386

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix for issue #385 #386

merged 1 commit into from
Nov 22, 2023

Conversation

UmmulkiramR
Copy link
Contributor

this fix addresses the issue where some blobs from Azure miss the value for contentMd5 property which breaks the download.

@UmmulkiramR UmmulkiramR requested a review from leoraba November 22, 2023 18:04
Copy link
Contributor

@leoraba leoraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@UmmulkiramR UmmulkiramR merged commit 11337b5 into develop Nov 22, 2023
3 checks passed
@UmmulkiramR UmmulkiramR deleted the azure_download_fail_#385 branch November 22, 2023 18:35
@UmmulkiramR UmmulkiramR linked an issue Nov 24, 2023 that may be closed by this pull request
UmmulkiramR added a commit that referenced this pull request Nov 27, 2023
* Readme updated

* mergeback for 5.9.1-SNAPSHOT

* updated readme copy

* updated readme copy

* Update README.md

Co-authored-by: Jon Eubank <joneubank@gmail.com>

* CORS configurations for score server allowing multiple origins at once - #367

* Organizing score-server application.yml

* docker JRE ireplacing JRE alpine image to support multiple architecturesmage multi arch supported

* latest ubuntu LTS 22.04 score client

* using JDK image as builder

* update docker dind (#376)

from docker image docker:18.06-dind to docker:20.10-dind

* fix docker dind TLS (#379)

* increase Jenkins timeout (#380)

from 30 to 45 mins

* Fix/jenkins extend timeout (#381)

* increase Jenkins timeout

from 30 to 45 mins

* increase Jenkins timeout

from 45 to 60 mins

* increase jenkins timeout

* update DeployWithHelm job name in Jenkinsfile (#383)

* fix for issue #385 (#386)

Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca>

* Auto sync storage profiles #378 (#382)

* added server endpoint to get profiles

* change to switch score-client storage implementations

* cleared azure and s3 related entries app.yml

* some bug fixes and enhancements

* updated comment

* added test profile.

* added test profile.

* refactored code based on review comments - BaseController now returns a single profile value. The actual profile name and the profile value returned by the api are now different.

* debug logging removed

* replaced profile value

* updated readme

* updated readme

* added a test profile

* review changes
- Storage profile values now come from an enum in score-core
- test configuration created to mock storage profile bean
- users will be able to provide a default profile value when working with old score-server instances

* users will be able to provide a default profile value when working with old score-server instances

* config change

* added a test config in score server

---------

Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca>

* rc release. Includes
 - auto sync storage profiles - #387
 - azure download fails - #385
 - fix in Jenkins to build the Score docker image to run on amd/arm architectures and updating score-client image to use latest LTS Ubuntu- #374 

---------

Co-authored-by: Mitchell Shiell <59712867+MitchellShiell@users.noreply.github.com>
Co-authored-by: dahiyaAD <adahiya@oicr.on.ca>
Co-authored-by: dahiyaAD <123118704+dahiyaAD@users.noreply.github.com>
Co-authored-by: Jon Eubank <joneubank@gmail.com>
Co-authored-by: Leonardo Rivera <leorivera_88@hotmail.com>
Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - Azure download fails for some analyses
2 participants