Keycloak permission manager #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use a JWT decoder for testing - Remove unused clases - Remove JWT expired unit tests as validation is now implemented by Spring Security
Merged
UmmulkiramR
added a commit
that referenced
this pull request
Nov 27, 2023
* Readme updated * mergeback for 5.9.1-SNAPSHOT * updated readme copy * updated readme copy * Update README.md Co-authored-by: Jon Eubank <joneubank@gmail.com> * CORS configurations for score server allowing multiple origins at once - #367 * Organizing score-server application.yml * docker JRE ireplacing JRE alpine image to support multiple architecturesmage multi arch supported * latest ubuntu LTS 22.04 score client * using JDK image as builder * update docker dind (#376) from docker image docker:18.06-dind to docker:20.10-dind * fix docker dind TLS (#379) * increase Jenkins timeout (#380) from 30 to 45 mins * Fix/jenkins extend timeout (#381) * increase Jenkins timeout from 30 to 45 mins * increase Jenkins timeout from 45 to 60 mins * increase jenkins timeout * update DeployWithHelm job name in Jenkinsfile (#383) * fix for issue #385 (#386) Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca> * Auto sync storage profiles #378 (#382) * added server endpoint to get profiles * change to switch score-client storage implementations * cleared azure and s3 related entries app.yml * some bug fixes and enhancements * updated comment * added test profile. * added test profile. * refactored code based on review comments - BaseController now returns a single profile value. The actual profile name and the profile value returned by the api are now different. * debug logging removed * replaced profile value * updated readme * updated readme * added a test profile * review changes - Storage profile values now come from an enum in score-core - test configuration created to mock storage profile bean - users will be able to provide a default profile value when working with old score-server instances * users will be able to provide a default profile value when working with old score-server instances * config change * added a test config in score server --------- Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca> * rc release. Includes - auto sync storage profiles - #387 - azure download fails - #385 - fix in Jenkins to build the Score docker image to run on amd/arm architectures and updating score-client image to use latest LTS Ubuntu- #374 --------- Co-authored-by: Mitchell Shiell <59712867+MitchellShiell@users.noreply.github.com> Co-authored-by: dahiyaAD <adahiya@oicr.on.ca> Co-authored-by: dahiyaAD <123118704+dahiyaAD@users.noreply.github.com> Co-authored-by: Jon Eubank <joneubank@gmail.com> Co-authored-by: Leonardo Rivera <leorivera_88@hotmail.com> Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca>
joneubank
requested changes
Dec 1, 2023
There was a problem hiding this comment.
All the code looks great! Thanks for all the hard work updating versions adn getting security sorted.
I can't accept this without some amount of documentation included for how to switch security providers between Ego and Keycloak. Need to indicate how to configure Score to use each provider.
| clientSecret: pass | ||
| # Define a valid auth provider: ego or keycloak | ||
| provider: ego |
leoraba
force-pushed
the
keycloak-permission-manager
branch
from
1bf8158 to
cc5bc5d
Compare
5 tasks
|
Capturing need for documentation: #417 |
joneubank
approved these changes
Jul 3, 2024
leoraba
added a commit
that referenced
this pull request
Jul 4, 2024
* Keycloak permission manager (#387) * enable Keycloak apiKeys * setup security config and update mvn dependencies * junit missing dependency * unit test mock Jwt Decoder * fix unit test - use a JWT decoder for testing - Remove unused clases - Remove JWT expired unit tests as validation is now implemented by Spring Security * code format * test profile * docker-compose update images * add keycloak to docker compose * fix merge conflict * fix typo curl command * update keycloak system client and apikeys * version 5.11.0
leoraba
added a commit
that referenced
this pull request
Oct 9, 2024
* Versioning 5.10.1 * Rc/5.11.0 (#418) * Keycloak permission manager (#387) * enable Keycloak apiKeys * setup security config and update mvn dependencies * junit missing dependency * unit test mock Jwt Decoder * fix unit test - use a JWT decoder for testing - Remove unused clases - Remove JWT expired unit tests as validation is now implemented by Spring Security * code format * test profile * docker-compose update images * add keycloak to docker compose * fix merge conflict * fix typo curl command * update keycloak system client and apikeys * version 5.11.0 --------- Co-authored-by: Jon Eubank <joneubank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #373
Integrate Keycloak as an Authorization Server.
changes:
jwtas now JWT and ApiKeys auth configuration is already included insecureprofile