Skip to content
This repository has been archived by the owner on Nov 11, 2017. It is now read-only.

Doesn't remove <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir> #19

Open
icnocop opened this issue Jan 22, 2016 · 1 comment
Open

Doesn't remove <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir> #19

icnocop opened this issue Jan 22, 2016 · 1 comment
Labels
wontfix

Comments

@icnocop
Copy link

icnocop commented Jan 22, 2016

Running migrateToAutomaticPackageRestore.ps1 doesn't remove the following line in the project files:
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>

That line is added when Enabling NuGet Package Restore on the solution in Visual Studio 2013 Update 5 and NuGet Package Manager v2.8.60723.765.

Thank you.
@owen2
Copy link
Owner

owen2 commented Jan 25, 2016

This line doesn't appear to be harmful or prevent automatic package restore, so I'm not planning on removing it from projects at this time.

@owen2 owen2 added the wontfix label Jan 26, 2016
icnocop pushed a commit to icnocop/AutomaticPackageRestoreMigrationScript that referenced this issue Feb 27, 2016
Fixed issues owen2#18, owen2#19, and owen2#20
c92d82e 
owen2#18: Avoiding inserting blank lines at the end of project files by using [System.IO.File]::WriteAllText instead of out-file
owen2#19: Removed <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
owen2#20: Using the same file encoding when saving the file
@icnocop icnocop mentioned this issue Feb 27, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icnocop @owen2