This repository has been archived by the owner on Nov 11, 2017. It is now read-only.
Fixed issues #18, #19, and #20 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen2#18: Avoiding inserting blank lines at the end of project files by using [System.IO.File]::WriteAllText instead of out-file owen2#19: Removed <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir> owen2#20: Using the same file encoding when saving the file
| @@ -7,6 +9,7 @@ $listOfBadStuff = @( | |||
| "\s*<Import Project=""\$\(SolutionDir\)\\\.nuget\\NuGet\.targets"".*?/>", | |||
| "\s*<Target Name=""EnsureNuGetPackageBuildImports"" BeforeTargets=""PrepareForBuild"">(.|\n)*?</Target>" | |||
| "\s*<RestorePackages>\w*</RestorePackages>" | |||
| "\s*<SolutionDir Condition=""\$\(SolutionDir\) == '' Or \$\(SolutionDir\) == '\*Undefined\*'"">\.\.\\</SolutionDir>" | |||
There was a problem hiding this comment.
I can't accept this pull request because of this line. Some other tools might need this information to work! It also does not break automatic package restore.
There was a problem hiding this comment.
I've updated the code to optionally remove the SolutionDir property based on a command line parameter.
…DirProperty command line switch add Test solution and project
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18: Avoiding inserting blank lines at the end of project files by using
[System.IO.File]::WriteAllTextinstead ofout-file#19: Removed
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>#20: Using the same file encoding when saving the file