-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ anomalist: Improve automatic detection of new datasets #3429
Merged
pabloarosado
merged 5 commits into
try-different-anomaly-detectors
from
improve-new-datasets-detection
Oct 18, 2024
Merged
✨ anomalist: Improve automatic detection of new datasets #3429
pabloarosado
merged 5 commits into
try-different-anomaly-detectors
from
improve-new-datasets-detection
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pabloarosado
commented
Oct 18, 2024
•
edited
Loading
edited
- Simplify the way we detect new datasets, and with this speed up the start of Anomalist.
- Infer a variable mapping when indicator upgrader has not been yet executed.
Quick links (staging server):
Login: chart-diff: ✅No charts for review.Edited: 2024-10-18 10:55:06 UTC |
3 tasks
Marigold
reviewed
Oct 18, 2024
Marigold
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I'm a bit confused by the way we get new datasets, but I'll ask on slack.
pabloarosado
merged commit Oct 18, 2024
e65060d
into
try-different-anomaly-detectors
7 of 8 checks passed
pabloarosado
added a commit
that referenced
this pull request
Oct 18, 2024
* 🎉 anomalist: Experiment with different anomaly detection methods * Improve script to visualize anomalies * Improve visualization of anomalies, and try different methods * Improve cli * Some refactoring * Add useful comment * ✨ anomalist: Improve automatic detection of new datasets (#3429) * ✨ anomalist: Improve automatic detection of new datasets * Create new functions to detect new datasets, and speed up anomalist * Infer variable mapping * Use inferred variable mapping in Anomalist * Move function to get datasets info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.