Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add anomalist to owidbot #3431

Merged
merged 4 commits into from
Oct 21, 2024
Merged

✨ Add anomalist to owidbot #3431

merged 4 commits into from
Oct 21, 2024

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Oct 18, 2024

  • Add anomalist to owidbot, this will allow us to run it automatically after every commit on staging servers (it only runs new datasets)
  • Save dataset.sourceChecksum to anomalies table. This means we can skip computing anomalies unless a dataset changes (this is especially useful for owidbot and running anomalist on staging servers)
  • Function _load_datasets_new_ids to get new datasets (if it works, we can use it in anomalist app)

@Marigold Marigold marked this pull request as ready for review October 18, 2024 12:26
@owidbot
Copy link
Contributor

owidbot commented Oct 18, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-owidbot-anomalist

chart-diff: ✅ No charts for review.

Edited: 2024-10-18 12:30:07 UTC
Execution time: 3.69 seconds

@Marigold Marigold requested a review from pabloarosado October 18, 2024 13:08
Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Your way to detect new datasets is very simple and it makes sense. Two comments (probably better to discuss on slack):

  1. If this is meant to happen under the hood, then it would make sense to infer the variable mapping if indicator upgrader has not yet been executed, which is what I implemented on ✨ anomalist: Improve automatic detection of new datasets #3429
  2. It's not clear to me what should happen now if the user opens Anomalist. We need to adapt the app so that anomalies are automatically detected from database, or is that already working somehow? I suppose that loading anomalies for the new datasets from the start is the best option. And, if the user wants to check anomalies on other datasets, that should still be possible (but it will take a while to recalculate anomalies).

@Marigold
Copy link
Collaborator Author

  1. Yep, I'm waiting for you to merge your PRs, then I'll rebase and update my code to use your new features

We need to adapt the app so that anomalies are automatically detected from database, or is that already working somehow?

It's not working yet. You're right that it should select new datasets by default and load anomalies without needing to click on the button. I'll add it either in this PR or the next one.

@Marigold Marigold merged commit 0476593 into wizard-anomalist Oct 21, 2024
5 of 7 checks passed
@Marigold Marigold deleted the owidbot-anomalist branch October 21, 2024 07:30
@lucasrodes lucasrodes mentioned this pull request Nov 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants