Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity extension for favorites #3

Closed
PVince81 opened this issue Dec 3, 2014 · 5 comments
Closed

Activity extension for favorites #3

PVince81 opened this issue Dec 3, 2014 · 5 comments

Comments

@PVince81
Copy link

PVince81 commented Dec 3, 2014

Trigger activities on favorite/unfavorite.
Add column in the activity page “send change notification only for favorited files/folders”

Extend OCP\Activity\IExtension for that.

CC @nickvergessen

@nickvergessen
Copy link

I could take care of this if you want me to

@PVince81
Copy link
Author

PVince81 commented Dec 3, 2014

That would be nice, thanks.
But first we need to get the basic work merged: #2

@PVince81
Copy link
Author

The main part of the favorites features has been merged in core: owncloud/core#12360

@nickvergessen nickvergessen self-assigned this Dec 15, 2014
@nickvergessen
Copy link

Btw, does this really make much sense?
I mean we can easily do this, but in most cases you know that just marked it as favorite.

De-favoriting may make sense, so you can find the file quickly again and then re-favorite it, but that's what undo actions should be for.

@nickvergessen
Copy link

We don't really want that, self actions are disabled by default anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants