[WIP] Added tags/favorites support #2
Conversation
|
@nickvergessen FYI This is still WIP and doesn't work (JS loading issues, etc) |
Make sure that loading the favorites JS code doesn't break other pages that are not the files index page.
|
The "favorites" list is now populated. It is extremely experimental and uses a horribly wrong* approach. It seems we'll need to make many changes to core to support a proper approach. @icewind1991 I'll need your support for this: 3b864a1#diff-19747901543244a55807cbd25aac2737R71 Seems we'll need to add new API to be able to resolve fileids to proper Storage + FileInfo (FileInfo needs a Storage instance, which might be resolve-able based on the file id). Also the file list will need to return the correct path because we have a flat list of files, but every file must know its path relative to the current user (for shared files) |
| * Core | ||
| */ | ||
| $container->registerService('UserId', function(IContainer $c) { | ||
| return \OCP\User::getUser(); |
There was a problem hiding this comment.
Mhm. Why not inject IUser/IUserSession instead?
There was a problem hiding this comment.
I copied this from another app, so you might want to ask that person the same question 😉
|
|
|
|
|
Needs the following changes from core to work:
|
|
|
@PVince81 please use this travis.yaml - https://github.com/owncloud/files_antivirus/blob/master/.travis.yml - it will already setup core as required - including oracle - THX |
|
Ok thanks. Thing is, I used the |
that would be great - THX |
|
Obsolete. Favorites feature was moved to core owncloud/core#12360 as suggested by @jancborchardt This means the "metadata" app will stay empty until we work on the next step which is providing tags support (tag management, etc) inside this separate app. |
|
Hmm thinking about it, let's keep it open but I'll strip out the favorites part. |
|
🚧 WIP