Add favorites to files app #12360

PVince81 · 2014-11-21T14:48:12Z

Part of #2368

LukasReschke · 2014-11-21T18:55:30Z

apps/files/js/favoritesfilelist.js

+				},
+				type: 'GET',
+				beforeSend: function(xhr) {
+					xhr.setRequestHeader('OCS-APIREQUEST', 'true');


Killed with #12362

PVince81 · 2014-11-24T15:39:32Z

requires Improve FileActions JS to allow for custom rendering #12394 to be merged first (custom rendering for file actions)

PVince81 · 2014-11-24T21:00:45Z

Favorites kind of work now.

I used a horrendous approach to populate the tags inside the result: 5ea8c8c#diff-471be045dd1eb605d9a1197b9ba90560R51
@icewind1991 can you comment on this ? Any better ideas ? (apart from bundling the ids together)

Fix layout
Fix potential performance bottleneck
Submit ITags addition as separate PR (45ac3d3) + unit tests
Make "Favorites" list work as well

PVince81 · 2014-11-25T09:18:00Z

needs Add getTagsForObjects in ITags #12409 (tags APi extension) to be merged first

PVince81 · 2014-11-25T10:23:07Z

update docs

MorrisJobke · 2014-11-25T10:25:12Z

apps/files/controller/apicontroller.php

+	 * @param array  $tags array of tags
+	 */
+	public function updateFileMetadata($path, $tags) {
+		$view = new \OC\Files\View('/'.\OCP\User::getUser().'/files');


Please don't use private API. If there is no public API for this: create it ;)

PVince81 · 2014-11-25T10:44:06Z

to fix tags/proxy perf potential issue: look into doing the JOIN directly built-in in the FS layer instead of making it pluggable

PVince81 · 2014-11-25T14:11:25Z

After discussion with @karlitschek (#2368 (comment)), I moved the tags code into a separate app here: owncloud-archive/metadata#2

I'll keep this PR here to make the necessary API/hook/proxy changes in core to make that app work.

PVince81 · 2014-12-08T15:16:37Z

Talked with @icewind1991 and we decided to move the tags injection to the presentation layer (ajax/list.php) to prevent potential performance issues when parts of the code or apps are calling getDirectoryContents or getFileInfo even when they don't need the tags. Those parts of the code can always use the ITags handler to retrieve tags when needed.

PVince81 · 2014-12-15T14:51:23Z

@jancborchardt I removed the spinner as you asked, please try again.

ghost · 2014-12-15T15:31:00Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/4539/

Build result: FAILURE

[...truncated 16 lines...]Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git5588186876880144167.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12360/merge^{commit} # timeout=10 > git branch -a --contains cb5c32ade0d4fcb03e9309c09aba8dbf845a2ab7 # timeout=10 > git rev-parse remotes/origin/pr/12360/merge^{commit} # timeout=10Checking out Revision cb5c32ade0d4fcb03e9309c09aba8dbf845a2ab7 (origin/pr/12360/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f cb5c32ade0d4fcb03e9309c09aba8dbf845a2ab7First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 second
💣 Test FAILed. 💣

ghost · 2014-12-15T15:31:02Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/4541/

Build result: FAILURE

[...truncated 17 lines...]using GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git7205812824551924239.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12360/merge^{commit} # timeout=10 > git branch -a --contains e4050c3adab18bb3e5697910cf809fe88c34ff73 # timeout=10 > git rev-parse remotes/origin/pr/12360/merge^{commit} # timeout=10Checking out Revision e4050c3adab18bb3e5697910cf809fe88c34ff73 (origin/pr/12360/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f e4050c3adab18bb3e5697910cf809fe88c34ff73 > git rev-list 9075db939b68cfc6cf3cc07061c51624cec5acb4 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second
💣 Test FAILed. 💣

ghost · 2014-12-15T15:37:38Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/4546/

Build result: FAILURE

[...truncated 17 lines...]using GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git7644682796774668943.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12360/merge^{commit} # timeout=10 > git branch -a --contains b87d02551002cfded4d501cc3d2e2c4c7b69dcd2 # timeout=10 > git rev-parse remotes/origin/pr/12360/merge^{commit} # timeout=10Checking out Revision b87d02551002cfded4d501cc3d2e2c4c7b69dcd2 (origin/pr/12360/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f b87d02551002cfded4d501cc3d2e2c4c7b69dcd2 > git rev-list 9075db939b68cfc6cf3cc07061c51624cec5acb4 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second
💣 Test FAILed. 💣

jancborchardt · 2014-12-15T15:43:32Z

Works nicely! 👍

jancborchardt · 2014-12-15T15:44:24Z

@PVince81 what’s up with the Jenkins failures? Otherwise it seems good to go.

PVince81 · 2014-12-15T15:45:05Z

Thanks. Jenkins is sick recently, I'll push the PR again for the tests.

Would be good if someone could review the code.
@icewind1991 @MorrisJobke @LukasReschke ?

PVince81 · 2014-12-15T15:46:04Z

Jenkins test here: #12859

LukasReschke · 2014-12-15T15:46:18Z

apps/files/appinfo/application.php

+
+        /**
+         * Core
+         */


Tabs + Spaces

PVince81 · 2014-12-15T16:21:01Z

Fixed in 207d77e

scrutinizer-notifier · 2014-12-15T17:30:23Z

The inspection completed: 16 new issues, 13 updated code elements

ghost · 2014-12-15T17:35:57Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/4554/

Build result: FAILURE

[...truncated 16 lines...]Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git8428475028823098557.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12360/merge^{commit} # timeout=10 > git branch -a --contains 54e21ef77770c1b44f19bdb6185c21bc5eb36ba2 # timeout=10 > git rev-parse remotes/origin/pr/12360/merge^{commit} # timeout=10Checking out Revision 54e21ef77770c1b44f19bdb6185c21bc5eb36ba2 (origin/pr/12360/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 54e21ef77770c1b44f19bdb6185c21bc5eb36ba2First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 1 second
💣 Test FAILed. 💣

LukasReschke · 2014-12-15T18:55:15Z

👍

Add favorites to files app

PVince81 self-assigned this Nov 21, 2014

PVince81 added the enhancement - proposed label Nov 21, 2014

LukasReschke reviewed Nov 21, 2014
View reviewed changes

PVince81 force-pushed the files-tags branch from f8cf3c9 to 71bb573 Compare November 24, 2014 16:56

PVince81 mentioned this pull request Nov 24, 2014

Files app favorites #2368

Closed

PVince81 force-pushed the files-tags branch from 5ea8c8c to 03fb639 Compare November 25, 2014 09:14

PVince81 added this to the 8.0-current milestone Nov 25, 2014

MorrisJobke reviewed Nov 25, 2014
View reviewed changes

PVince81 force-pushed the files-tags branch from 0fef77e to 4a45f87 Compare November 25, 2014 14:08

PVince81 force-pushed the files-tags branch from 4a45f87 to 7ff71b5 Compare November 27, 2014 15:37

PVince81 changed the title ~~[WIP] Favorites file list~~ [WIP] Core changes for tags/favorites for the metadata app Nov 28, 2014

PVince81 force-pushed the files-tags branch 2 times, most recently from bedc636 to 3624130 Compare December 1, 2014 16:57

PVince81 mentioned this pull request Dec 4, 2014

[WIP] Added tags/favorites support owncloud-archive/metadata#2

Closed

PVince81 force-pushed the files-tags branch from b13575d to c903729 Compare December 4, 2014 17:03

PVince81 mentioned this pull request Dec 8, 2014

Extend file node API with getFileInfo #12614

Closed

PVince81 force-pushed the files-tags branch from c903729 to e746d16 Compare December 9, 2014 13:28

MorrisJobke added the 2 - Developing label Dec 9, 2014

PVince81 changed the title ~~[WIP] Core changes for tags/favorites for the metadata app~~ Add favorites to files app Dec 11, 2014

PVince81 mentioned this pull request Dec 11, 2014

Move file thumbnail element into the label tag #12795

Merged

PVince81 mentioned this pull request Dec 15, 2014

Provide API endpoints for favorites/metadata/tags on files #12337

Closed

PVince81 added 3 - To Review and removed 2 - Developing labels Dec 15, 2014

PVince81 mentioned this pull request Dec 15, 2014

[NOMERGE JENKINS ONLY] Files tags #12859

Merged

LukasReschke reviewed Dec 15, 2014
View reviewed changes

apps/files/appinfo/application.php

/**

* Core

*/

Copy link

Member

LukasReschke Dec 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs + Spaces

Fixed small code style issues

207d77e

LukasReschke added a commit that referenced this pull request Dec 15, 2014

Merge pull request #12360 from owncloud/files-tags

be3d4fd

Add favorites to files app

LukasReschke merged commit be3d4fd into master Dec 15, 2014

LukasReschke deleted the files-tags branch December 15, 2014 18:55

PVince81 mentioned this pull request Dec 15, 2014

Activity extension for favorites owncloud-archive/metadata#3

Closed

jancborchardt mentioned this pull request Dec 17, 2014

Star folders/files #10912

Closed

MorrisJobke mentioned this pull request Jan 16, 2015

Rename field in "Favorites" is shifted to the right #13338

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add favorites to files app #12360

Add favorites to files app #12360

PVince81 commented Nov 21, 2014

LukasReschke Nov 21, 2014

PVince81 commented Nov 24, 2014

PVince81 commented Nov 24, 2014

PVince81 commented Nov 25, 2014

PVince81 commented Nov 25, 2014

MorrisJobke Nov 25, 2014

PVince81 commented Nov 25, 2014

PVince81 commented Nov 25, 2014

PVince81 commented Dec 8, 2014

PVince81 commented Dec 15, 2014

ghost commented Dec 15, 2014

ghost commented Dec 15, 2014

ghost commented Dec 15, 2014

jancborchardt commented Dec 15, 2014

jancborchardt commented Dec 15, 2014

PVince81 commented Dec 15, 2014

PVince81 commented Dec 15, 2014

LukasReschke Dec 15, 2014

PVince81 commented Dec 15, 2014

scrutinizer-notifier commented Dec 15, 2014

ghost commented Dec 15, 2014

LukasReschke commented Dec 15, 2014

Add favorites to files app #12360

Add favorites to files app #12360

Conversation

PVince81 commented Nov 21, 2014

LukasReschke Nov 21, 2014

Choose a reason for hiding this comment

PVince81 commented Nov 24, 2014

PVince81 commented Nov 24, 2014

PVince81 commented Nov 25, 2014

PVince81 commented Nov 25, 2014

MorrisJobke Nov 25, 2014

Choose a reason for hiding this comment

PVince81 commented Nov 25, 2014

PVince81 commented Nov 25, 2014

PVince81 commented Dec 8, 2014

PVince81 commented Dec 15, 2014

ghost commented Dec 15, 2014

Build result: FAILURE

ghost commented Dec 15, 2014

Build result: FAILURE

ghost commented Dec 15, 2014

Build result: FAILURE

jancborchardt commented Dec 15, 2014

jancborchardt commented Dec 15, 2014

PVince81 commented Dec 15, 2014

PVince81 commented Dec 15, 2014

LukasReschke Dec 15, 2014

Choose a reason for hiding this comment

PVince81 commented Dec 15, 2014

scrutinizer-notifier commented Dec 15, 2014

ghost commented Dec 15, 2014

Build result: FAILURE

LukasReschke commented Dec 15, 2014