Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCS API header per default #12362

Merged
merged 1 commit into from
Nov 24, 2014
Merged

Add OCS API header per default #12362

merged 1 commit into from
Nov 24, 2014

Conversation

LukasReschke
Copy link
Member

Relieve @pvince from having to write it all the time ;-)

Relieve @pvince from having to write it all the time ;-)
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@ghost
Copy link

ghost commented Nov 21, 2014

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3066/
🚀 Test PASSed. 🚀

@PVince81
Copy link
Contributor

Thanks... but are you sure ? There were reasons for that header ? @DeepDiver1975

I'll still need to keep them in pyocclient to keep compatible with OC 6/7.

@LukasReschke
Copy link
Member Author

Thanks... but are you sure ? There were reasons for that header ? @DeepDiver1975

Yes. I am sure. I added that header 😉

It is only to to prevent being the cookies re-used from another domain. It's fine doing that here ;-)

@LukasReschke
Copy link
Member Author

I'll still need to keep them in pyocclient to keep compatible with OC 6/7.

Sure. That code only adds it to all jQuery AJAX requests done from oC JS ;-)

@PVince81
Copy link
Contributor

Ah yes, it was late and I didn't look at the code.
But will it affect regular ajax calls (the non-OCS ones ?), I guess it won't ?

@LukasReschke
Copy link
Member Author

But will it affect regular ajax calls (the non-OCS ones ?), I guess it won't ?

It will add the header as well there, but that doesn't matter (it's simply not processed further). The CSRF token is also sent with every request even if not necessarily needed in every case.

@DeepDiver1975
Copy link
Member

fine with me 👍

@PVince81
Copy link
Contributor

👍

PVince81 pushed a commit that referenced this pull request Nov 24, 2014
@PVince81 PVince81 merged commit 49ad10c into master Nov 24, 2014
@PVince81 PVince81 deleted the add-ocs-header-per-default branch November 24, 2014 10:09
@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants