Added searchByTags to view, storage and cache #12617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Logout the current user and tear down the filesystem. | ||
| */ | ||
| static protected function logout() { | ||
| \OC_Util::tearDownFS(); |
There was a problem hiding this comment.
check whether we are already logged out, since this might be expensive?
There was a problem hiding this comment.
I looked into its impl, it just clears a few arrays so shoulnd't be expensive.
Also we don't do it every time automatically, the test writers must decide whether to use it or not. (encryption/sharing have their own helpers which can be redirected to this later)
PVince81
force-pushed
the
searchbytags
branch
from
7e9ec8c to
28fc830
Compare
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 16 lines...]Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git5763326909978540880.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12617/merge^{commit} # timeout=10 > git branch -a --contains 053c152a47dced5a3ff784aed6ae3aa9120dc1da # timeout=10 > git rev-parse remotes/origin/pr/12617/merge^{commit} # timeout=10Checking out Revision 053c152a47dced5a3ff784aed6ae3aa9120dc1da (origin/pr/12617/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 053c152a47dced5a3ff784aed6ae3aa9120dc1daFirst time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second💣 Test FAILed. 💣 |
|
|
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 18 lines...]using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git2065754973029294132.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12617/merge^{commit} # timeout=10 > git branch -a --contains 0db54fc8c7e4ff66e08fc6c5e5268c53a5e678d9 # timeout=10 > git rev-parse remotes/origin/pr/12617/merge^{commit} # timeout=10Checking out Revision 0db54fc8c7e4ff66e08fc6c5e5268c53a5e678d9 (origin/pr/12617/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 0db54fc8c7e4ff66e08fc6c5e5268c53a5e678d9First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVETriggering pull-request-analyser-ng-simple » vm-slave-03pull-request-analyser-ng-simple » SLAVE completed with result FAILUREpull-request-analyser-ng-simple » vm-slave-03 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 49 second💣 Test FAILed. 💣 |
PVince81
force-pushed
the
searchbytags
branch
from
f6190b6 to
c40de59
Compare
|
Had to add an argument when loading the tags to make it possible to load tags for a different user than the one who is logged in: https://github.com/owncloud/core/pull/12617/files#diff-53358c86f0b4846db05fafd172a73d56R56 Also I fixed Please review @icewind1991 @nickvergessen @LukasReschke |
| * @return \OCP\ITags | ||
| */ | ||
| public function load($type, $defaultTags=array(), $includeShared=false) { | ||
| return new Tags($this->mapper, $this->user, $type, $defaultTags, $includeShared); | ||
| public function load($type, $defaultTags = array(), $includeShared = false, $user = null) { |
There was a problem hiding this comment.
Enforce type? \OCP\IUser $user
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 16 lines...]Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git1939264008145441972.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12617/merge^{commit} # timeout=10 > git branch -a --contains 130ba7367b54730e14dc003f5dd6b5612fee330e # timeout=10 > git rev-parse remotes/origin/pr/12617/merge^{commit} # timeout=10Checking out Revision 130ba7367b54730e14dc003f5dd6b5612fee330e (origin/pr/12617/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 130ba7367b54730e14dc003f5dd6b5612fee330eFirst time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 20 second💣 Test FAILed. 💣 |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 16 lines...]Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git1046696498170140206.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12617/merge^{commit} # timeout=10 > git branch -a --contains cfd3791913bd93bfb5f0086248b35a9e9be4e52a # timeout=10 > git rev-parse remotes/origin/pr/12617/merge^{commit} # timeout=10Checking out Revision cfd3791913bd93bfb5f0086248b35a9e9be4e52a (origin/pr/12617/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f cfd3791913bd93bfb5f0086248b35a9e9be4e52aFirst time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second💣 Test FAILed. 💣 |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 17 lines...]using GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git1231165357666126773.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12617/merge^{commit} # timeout=10 > git branch -a --contains 5cca59171d211ce0d35fb662a28b644f061cece1 # timeout=10 > git rev-parse remotes/origin/pr/12617/merge^{commit} # timeout=10Checking out Revision 5cca59171d211ce0d35fb662a28b644f061cece1 (origin/pr/12617/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 5cca59171d211ce0d35fb662a28b644f061cece1 > git rev-list 130ba7367b54730e14dc003f5dd6b5612fee330e # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second💣 Test FAILed. 💣 |
|
Superseded by #12778 |
|
The inspection completed: 16 new issues, 13 updated code elements |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to be able to get a flat result list of all favorites.
@icewind1991 @schiesbn @nickvergessen please review