Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

desktop client: 2.3.3 rc2 #1256

Merged
merged 1 commit into from
Aug 18, 2017
Merged

desktop client: 2.3.3 rc2 #1256

merged 1 commit into from
Aug 18, 2017

Conversation

guruz
Copy link
Contributor

@guruz guruz commented Aug 18, 2017

@stkjj @lefherz Please check on staging then deploy

@guruz guruz mentioned this pull request Aug 18, 2017
84 tasks
@jnweiger jnweiger merged commit 7e95ba1 into master Aug 18, 2017
@jnweiger
Copy link
Contributor

Merge into staging, so that @lefherz can check it there.

Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page desktop replicates many values that are in the strings.php. That calls for inconsistencies. Why don't we expand the variables from strings.php in page-desktop.php ?

@guruz
Copy link
Contributor Author

guruz commented Aug 18, 2017

@jnweiger Could do that, but page-desktop is the whole changelog.. so at some point when doing the next release you need to anyway have those previous release links

@guruz
Copy link
Contributor Author

guruz commented Aug 18, 2017

Tested on staging, all download links work.

@lefherz please ping when deploiyed to production

@jnweiger
Copy link
Contributor

Emil checked, gave me permission to deploy. He is on the run.

@jnweiger jnweiger deleted the client233rc2 branch August 18, 2017 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants