feat: add mdpresentation-viewer app to apps.json #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
force-pushed
the
add-mdpresentation-viewer-app
branch
from
c1b6602 to
6d3fe2a
Compare
saw-jan
commented
Aug 30, 2024
There was a problem hiding this comment.
Should it be under webApps/jankaritech/mdpresentation-viewer/cover.png as mentioned in #8 (review) ?
CC @kulmann
There was a problem hiding this comment.
Should webApps/<org-name>/<repo-name> be strict? if yes then the path would become webApps/jankaritech/web-app-presentation-viewer/cover.png
There was a problem hiding this comment.
moved to webApps/jankaritech/web-app-presentation-viewer/
saw-jan
force-pushed
the
add-mdpresentation-viewer-app
branch
from
6d3fe2a to
c3486cf
Compare
saw-jan
force-pushed
the
add-mdpresentation-viewer-app
branch
from
c3486cf to
cfe0bbb
Compare
|
I didn't notice this PR, sorry 🙈 waiting for feedback about default CSP rules, see owncloud/ocis#9993 - if that's getting included in the next ocis rolling release (tomorrow) we can merge here. Otherwise I'd like to add some description about the necessity to add a CSP rule. |
koebel
reviewed
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mdpresentation-viewer app.
Closes JankariTech/web-app-presentation-viewer#67