Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding screenshots and cover image for dicom viewer web extension #8

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

koebel
Copy link
Contributor

@koebel koebel commented Aug 13, 2024

relates to owncloud/web#11330 and owncloud/web-app-dicom-viewer#48

regarding image sources:

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a different folder structure in mind, maybe I should place a readme.

webApps/<org-name>/<repo-name>/<app-name if needed>/cover.png

In you case:
webApps/owncloud/web-app-dicom-viewer/cover.png (this the repo is only for a single app I don't see a reason to include the app name again after the repo name).

Could you change that please? 😇

@koebel koebel changed the title adding cover image for dicom viewer web extension adding screenshots and cover image for dicom viewer web extension Sep 5, 2024
@kulmann kulmann merged commit cafb875 into main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants